nodejs/nodebestpractices
1
0
Fork 0
mirror of https://github.com/goldbergyoni/nodebestpractices.git synced 2025-11-01 10:26:49 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2 from goldbergyoni/master

Browse Source 
updating fork
This commit is contained in:
Andrew Barbour
2021-02-12 14:18:35 -08:00
committed by GitHub
parent 4d448ea699 a1f8716bbb
commit e7db59b9ec
3 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
.all-contributorsrc
View File

@ -1295,6 +1295,15 @@
"contributions": [ "contributions": [
"content" "content"
] ]
},
{
"login": "kubanac95",
"name": "Aleksandar",
"avatar_url": "https://avatars.githubusercontent.com/u/16191931?v=4",
"profile": "https://github.com/kubanac95",
"contributions": [
"content"
]
} }
], ],
"projectName": "nodebestpractices", "projectName": "nodebestpractices",

1
README.md
View File

@ -1563,6 +1563,7 @@ Thanks goes to these wonderful people who have contributed to this repository!
<td align="center"><a href="https://github.com/YA21"><img src="https://avatars.githubusercontent.com/u/37298463?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Yuta Azumi</b></sub></a><br /><a href="#content-YA21" title="Content">🖋</a></td> <td align="center"><a href="https://github.com/YA21"><img src="https://avatars.githubusercontent.com/u/37298463?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Yuta Azumi</b></sub></a><br /><a href="#content-YA21" title="Content">🖋</a></td>
<td align="center"><a href="https://github.com/andrewjbarbour"><img src="https://avatars.githubusercontent.com/u/77080074?v=4?s=100" width="100px;" alt=""/><br /><sub><b>andrewjbarbour</b></sub></a><br /><a href="#content-andrewjbarbour" title="Content">🖋</a></td> <td align="center"><a href="https://github.com/andrewjbarbour"><img src="https://avatars.githubusercontent.com/u/77080074?v=4?s=100" width="100px;" alt=""/><br /><sub><b>andrewjbarbour</b></sub></a><br /><a href="#content-andrewjbarbour" title="Content">🖋</a></td>
<td align="center"><a href="https://MasujimaRyohei.jp"><img src="https://avatars.githubusercontent.com/u/17163541?v=4?s=100" width="100px;" alt=""/><br /><sub><b>mr</b></sub></a><br /><a href="#content-MasujimaRyohei" title="Content">🖋</a></td> <td align="center"><a href="https://MasujimaRyohei.jp"><img src="https://avatars.githubusercontent.com/u/17163541?v=4?s=100" width="100px;" alt=""/><br /><sub><b>mr</b></sub></a><br /><a href="#content-MasujimaRyohei" title="Content">🖋</a></td>
<td align="center"><a href="https://github.com/kubanac95"><img src="https://avatars.githubusercontent.com/u/16191931?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Aleksandar</b></sub></a><br /><a href="#content-kubanac95" title="Content">🖋</a></td>
</tr> </tr>
</table> </table>

2
sections/errorhandling/centralizedhandling.md
View File

@ -104,7 +104,7 @@ function errorHandler() {
```typescript ```typescript
class ErrorHandler { class ErrorHandler {
public async handleError(err: Error, responseStream: Response): Promise<void> { public async handleError(error: Error, responseStream: Response): Promise<void> {
await logger.logError(error); await logger.logError(error);
await fireMonitoringMetric(error); await fireMonitoringMetric(error);
await crashIfUntrustedErrorOrSendResponse(error, responseStream); await crashIfUntrustedErrorOrSendResponse(error, responseStream);