nodejs/nodebestpractices
1
0
Fork 0
mirror of https://github.com/goldbergyoni/nodebestpractices.git synced 2025-11-02 19:18:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #756 from goldbergyoni/Add-a-zombie

Browse Source 
Add missing `zombie` word in 8.2 BP
This commit is contained in:
Kevyn Bruyere
2020-08-24 14:44:42 +02:00
committed by GitHub
parent e74183fd5b d77eb0c053
commit e05e587dbc
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
README.md
View File

@ -1114,7 +1114,7 @@ CMD [ "node", "dist/app.js" ]
## ![✔] 8.2. Bootstrap using 'node' command, avoid npm start
**TL;DR:** use `CMD ['node','server.js']` to start your app, avoid using npm scripts which don't pass OS signals to the code. This prevents problems with child-process, signal handling, graceful shutdown and having processes.
**TL;DR:** use `CMD ['node','server.js']` to start your app, avoid using npm scripts which don't pass OS signals to the code. This prevents problems with child-process, signal handling, graceful shutdown and having zombie processes.
**Otherwise:** When no signals are passed, your code will never be notified about shutdowns. Without this, it will lose its chance to close properly possibly losing current requests and/or data.