nodejs/nodebestpractices
1
0
Fork 0
mirror of https://github.com/goldbergyoni/nodebestpractices.git synced 2025-10-30 09:05:43 +08:00
Code Issues Packages Projects Releases Wiki Activity

http request example

Browse Source
This commit is contained in:
Yedidya
2021-02-05 11:07:59 +02:00
parent c1a3da1c69
commit 1af7f012f4
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
sections/production/assigntransactionid.md
View File

@ -25,13 +25,11 @@ app.get('/getUserData/{id}', async (req, res, next) => {
// At any point in the app after cls-rtracer middleware was initialized, even when 'req' object doesn't exist, the TransactionId is reachable // At any point in the app after cls-rtracer middleware was initialized, even when 'req' object doesn't exist, the TransactionId is reachable
const transactionId = rTracer.id(); const transactionId = rTracer.id();
logger.info(`user ${user.id} data was fetched successfully`, { transactionId }); logger.info(`user ${user.id} data was fetched successfully`, { transactionId });
res.json(user); res.json(user);
} catch (err) { } catch (err) {
// If not for the example, I'd recommand using rTracer.id() from inside the logger component, to prevent from using it all over the code
// As next step I'd recommand using rTracer.id() from inside the logger component, to prevent from using it all over the code
logger.error(`error while fetching user id ${req.params.id} data`, { transactionId: rTracer.id(), error: err }); logger.error(`error while fetching user id ${req.params.id} data`, { transactionId: rTracer.id(), error: err });
next(err); next(err);
@ -53,10 +51,14 @@ app.use(rTracer.expressMiddleware({
headerName: 'x-transaction-id' headerName: 'x-transaction-id'
})); }));
const axios = require("axios");
// Now, the external service will automaticlly get the current TransactionId as header
const response = await axios.get('https://externalService.com/api/getAllUsers');
``` ```
<br/><br/> <br/><br/>
### Good: Logs with an assigned TransactionId - can be used it as filter to see only a single flow ### Good: Logs with an assigned TransactionId - can be used as filter to see only a single flow
![alt text](https://i.ibb.co/YjJwgbN/logs-with-transaction-id.jpg "Logs with transaction id") ![alt text](https://i.ibb.co/YjJwgbN/logs-with-transaction-id.jpg "Logs with transaction id")
<br/><br/> <br/><br/>