javascript/react-diagrams
1
0
Fork 0
mirror of https://github.com/projectstorm/react-diagrams.git synced 2025-08-26 07:51:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

Always remove link from old source/target port on port change

Browse Source 
Was only removed from old if new port is null
This commit is contained in:
Mattias Wadman
2018-03-23 13:24:32 +01:00
parent 47214df76b
commit 7a78aaa9fd
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/models/LinkModel.ts
View File

@ -151,10 +151,9 @@ export class LinkModel<T extends LinkModelListener = LinkModelListener> extends
setSourcePort(port: PortModel) { setSourcePort(port: PortModel) {
if (port !== null) { if (port !== null) {
port.addLink(this); port.addLink(this);
} else if (this.sourcePort !== null) { }
if (this.sourcePort !== null) {
this.sourcePort.removeLink(this); this.sourcePort.removeLink(this);
} else {
return;
} }
this.sourcePort = port; this.sourcePort = port;
this.iterateListeners((listener: LinkModelListener, event) => { this.iterateListeners((listener: LinkModelListener, event) => {
@ -175,10 +174,9 @@ export class LinkModel<T extends LinkModelListener = LinkModelListener> extends
setTargetPort(port: PortModel) { setTargetPort(port: PortModel) {
if (port !== null) { if (port !== null) {
port.addLink(this); port.addLink(this);
} else if (this.targetPort !== null) { }
if (this.targetPort !== null) {
this.targetPort.removeLink(this); this.targetPort.removeLink(this);
} else {
return;
} }
this.targetPort = port; this.targetPort = port;
this.iterateListeners((listener: LinkModelListener, event) => { this.iterateListeners((listener: LinkModelListener, event) => {