javascript/makemeahanzi
1
0
Fork 0
mirror of https://github.com/skishore/makemeahanzi.git synced 2025-11-02 21:41:28 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix bugs in stroke extraction code

Browse Source
This commit is contained in:
Shaunak Kishore
2015-09-20 16:10:39 -04:00
parent 4096c2e602
commit 9655198357
2 changed files with 18 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
lib/stroke_extractor.js
View File

@ -110,12 +110,12 @@ function orient_paths(paths) {
var result = []; var result = [];
for (var i = 0; i < paths.length; i++) { for (var i = 0; i < paths.length; i++) {
var path = paths[i]; var path = paths[i];
for (var j = 0; j < paths.length; j++) { for (var j = 0; j < path.length; j++) {
var ref = [path[j].start, path[j].end]; var ref = [path[j].start, path[j].end];
path[j].start = ref[1]; path[j].start = ref[1];
path[j].end = ref[0]; path[j].end = ref[0];
} }
path[j].reverse(); path.reverse();
} }
} }
return paths; return paths;
@ -127,7 +127,8 @@ function get_2x_area(path) {
var area = 0; var area = 0;
for (var i = 0; i < path.length; i++) { for (var i = 0; i < path.length; i++) {
var segment = path[i]; var segment = path[i];
area += (segment.end.x - segment.start.x)*(segment.end.y + segment.start.y); area += (segment.end[0] + segment.start[0])*
(segment.end[1] - segment.start[1]);
} }
return area; return area;
} }
@ -514,7 +515,12 @@ this.get_glyph_render_data = function(glyph, manual_bridges, classifier) {
var strokes = extract_strokes( var strokes = extract_strokes(
paths, endpoints, manual_bridges || bridges, log); paths, endpoints, manual_bridges || bridges, log);
var expected = UNIHAN_STROKE_COUNTS[glyph.name]; var expected = UNIHAN_STROKE_COUNTS[glyph.name];
if (strokes.length === expected) { log.push(['success', 'For character: ' +
String.fromCodePoint(parseInt(glyph.name.substr(3), 16))]);
if (expected === undefined) {
log.push(['success', 'Extracted ' + strokes.length + ' stroke' +
(strokes.length > 1 ? 's' : '') + '.']);
} else if (strokes.length === expected) {
log.push(['success', 'Extracted ' + strokes.length + ' stroke' + log.push(['success', 'Extracted ' + strokes.length + ' stroke' +
(strokes.length > 1 ? 's' : '') + '.']); (strokes.length > 1 ? 's' : '') + '.']);
} else { } else {

14
server/glyphs.js
View File

@ -1,12 +1,14 @@
function save_glyph(glyph) { function save_glyph(glyph) {
check(glyph.name, String); check(glyph.name, String);
var saved_glyph = _.extend({}, glyph); var saved_glyph = _.extend({}, glyph);
saved_glyph.derived = { if (saved_glyph.render !== undefined) {
errors: saved_glyph.render.log.filter(function(pair) { saved_glyph.derived = {
return pair[0] !== 'success'; errors: saved_glyph.render.log.filter(function(pair) {
}), return pair[0] !== 'success';
strokes: saved_glyph.render.strokes, }),
}; strokes: saved_glyph.render.strokes,
};
}
delete saved_glyph.render; delete saved_glyph.render;
Glyphs.upsert({name: glyph.name}, saved_glyph); Glyphs.upsert({name: glyph.name}, saved_glyph);
return glyph; return glyph;