mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-16 18:17:31 +08:00

Files

Maria Hutt e8e5c4e1b6 refactor(dark): use palettes through url queries in test pages (#29238 )

Issue number: N/A

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

If a dev wants to view a test page in dark mode, they have to manually
add the styles. This can lead to a slowdown. Plus they can't use
Playwright's `goto` to test both light and dark. In order to test dark
mode with Playwright, the dev would need to use `setContent` instead of
`goto`.

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

Dark mode can be added to any page by appending `palette=dark` to the
URL.

- The param will be used to add a link tag with the correct palette
file.
- Playwright will load the correct palette file when a dev uses `goto`
and `{ themes: ['dark'] }`

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!--
  If this introduces a breaking change:
1. Describe the impact and migration path for existing applications
below.
  2. Update the BREAKING.md file with the breaking change.
3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
See
https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer
for more information.
-->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

I recommend using badge to try this out. It already has a `goto` in the
basic tests.

2024-04-19 18:48:29 +00:00

custom-elements

feat(custom-elements): add experimental custom elements build (#22863 )

2021-02-11 12:08:00 -05:00

testing

refactor(dark): use palettes through url queries in test pages (#29238 )

2024-04-19 18:48:29 +00:00

api-spec-generator.js

chore(api): update api generator to include parts in the public API (#21110 )

2020-04-22 15:41:44 -04:00

clean.js

fix(): update to Stencil One 🎉🎊