ionic-framework

mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-10 00:27:41 +08:00

Files

Brandy Carney d47b7e7503 fix(tab-bar): apply safe area to proper side regardless of direction (#28372 )

Issue number: Internal

---------

## What is the current behavior?
The safe area padding (both left and right) swap sides when the app's
direction changes from LTR to RTL. The `--ion-safe-area-left` should
always apply to the left side of the device and the
`--ion-safe-area-right` should always apply to the right side of the
device.

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Updates the tab bar stylesheet to always set `padding-left` and
`padding-right`
- Adds an e2e test for the basic directory which adds screenshots in
both modes/directions for:
  - the default tab bar
  - a tab bar with safe area left applied
  - a tab bar with safe area right applied

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

---------

Co-authored-by: ionitron <hi@ionicframework.com>

2023-10-25 15:48:47 +00:00

test

fix(tab-bar): apply safe area to proper side regardless of direction (#28372 )

2023-10-25 15:48:47 +00:00

tab-bar-interface.ts

docs(all): improve type docs for event

2018-12-28 20:38:24 +01:00

tab-bar.ios.scss

feat(components): improve button states and add new css properties (#19440 )

2020-01-23 16:57:47 -05:00

tab-bar.ios.vars.scss

fix(tab-bar): add translucent tab-bar styles back (#17376 )