mirror of
https://github.com/ionic-team/ionic-framework.git
synced 2025-08-14 16:52:26 +08:00
32bc33ed28
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> The `angular` directory sits at the root of the project instead of in `packages` with all the other JS Framework integrations. This does not cause any functional issues with Ionic, but it is confusing since integrations are not in a consistent place. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Moves the `angular` directory to `packages/angular` Note: Most files should remain unchanged. The only files I changed are the files that had direct paths to the old `angular` directory: 1. Removes the `angular` path in `lerna.json`. This is now covered by `packages/*` 2. Updated the angular file path in `.gitignore` 3. Updates the path to the angular package in `stencil.config.ts` for the Angular Output Targets 4. Updates some of Angular's sync scripts to correctly get the core stylesheets as well as the core package. 5. Updates the test app sync script to correctly sync core and angular-server ~I'm not entirely sure why GitHub thinks https://github.com/ionic-team/ionic-framework/pull/27719/files#diff-f5bba7e7c7c75426e2b9c89868310cb03890493b4efe0252adf8d12cc8398962 is a new file since it exists in `main` here:1f06be4a31/angular/test/base/scripts/build-ionic.sh~Fixed in6e7fc49827## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev build: `7.1.2-dev.11688052109.13454f5c`
Local @ionic/angular test/testapp development
npm installat the root ofangularnpm run build.devto build local@ionic/angularand@ionic/corecd test/testappto the test appnpm installin the test app directorynpm run servecopies packages and serve the app (see package.json for more options)- http://localhost:4200/
npm link local development
npm link doesn't work as expected due to the devDependency on @angular/core. This is the work around...
npm run build.link ../ionic-conference-app
When the command above is ran from the angular directory, it will build @ionic/angular and copy the dist directory to the correct location of another local project. In the example above, the end result is that it copies the dist directory to ../ionic-conference-app/node_modules/@ionic/angular/dist. The path given should be relative to the root of this mono repo.
package.json note
The package.json file in this directory references Ionic 3 and is in here to get GitHub to properly show the Used By counts on the repo. Do not remove it!