mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-15 17:42:15 +08:00

Files

Brandy Carney 0124f3b0b3 test(many): replace ionic buttons in e2e tests with native html buttons (#29422 )

Issue number: internal

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
The `ion-button` component is used in several tests to navigate or show
overlays. This causes screenshot diffs in unrelated tests any time the
UI of the `ion-button` is updated.

## What is the new behavior?
Removes the `ion-button` elements from unrelated tests. 

Did not remove the `ion-button`s from the following tests:
- All `ion-button`s in an `ion-buttons` component
- An `ion-button` inside of a menu
- breadcrumbs/test/basic (uses a clear button in a list header, needs to
be moved)
- input/test/slot
- item/test/buttons
- item/test/colors
- item/test/dividers
- item/test/inputs
- item/test/media
- list-header/test/basic
- ripple-effect/test/basic
- router/test/basic
- router/test/guards
- router-outlet/test/basic
- select/test/slot
- textarea/test/slot

Updates the icon/basic test to use the right icon names by comparing
against the v3 names: https://ionicframework.com/docs/v3/ionicons/

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

---------

Co-authored-by: ionitron <hi@ionicframework.com>

2024-05-02 19:20:48 +00:00

assets

docs(testing, components): clarify testing and focusable usage (#29424 )

2024-05-01 04:11:35 +00:00

api.md

docs(testing, components): clarify testing and focusable usage (#29424 )

2024-05-01 04:11:35 +00:00

best-practices.md

test(many): replace ionic buttons in e2e tests with native html buttons (#29422 )

2024-05-02 19:20:48 +00:00

preview-changes.md

chore(docs): consolidate the developer resource files into a docs/ directory (#29266 )

2024-04-08 19:06:26 +00:00

README.md

chore(docs): consolidate the developer resource files into a docs/ directory (#29266 )

2024-04-08 19:06:26 +00:00

usage-instructions.md

docs(testing): add correct command (#29441 )

2024-05-01 21:02:41 +00:00

Directory	Description
Preview Changes	Steps on building core and previewing changes
Usage Instructions	How to run tests and update screenshots
Best Practices	Contains information on conventions to follow as well as pitfalls to avoid when writing tests
API	Documents the custom functionality that has been built on top of Playwright

README.md

Core Testing

Directory