mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-20 20:33:32 +08:00

Files

Sean Perkins d20bea561c fix(angular): tabs supports conditional slot bindings (#27582 )

Issue number: Resolves #19484

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

The Angular implementation of `ion-tabs` does not support conditional
binding the `slot` property on `ion-tab-bar` or assigning a variable as
the slot.

For example, this usage is invalid:

```html
<ion-tabs>
  <ion-tab-bar [slot]="slot"></ion-tab-bar>
</ion-tabs>
```

This occurs because `ng-content` only supports static content
projection. It is not intended for scenarios where the content can be
relocated or conditionally rendered.

An example of static content projection would be:
```html
<ion-tabs>
  <ion-tab-bar slot="top"></ion-tab-bar>
</ion-tabs>
```

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- `ion-tabs` supports conditional slot bindings or a slot that is bound
to a variable in Angular.

The revised implementation relocates the tab bar in the `ion-tabs`
template, based on it's current slot attribute. The implementation
checks the tab bar slot whenever the content changes.

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

Dev-build: `7.0.11-dev.11685631370.18980633`

---------

Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>

2023-06-06 22:41:33 -04:00

scripts

chore(ci): enable npm package provenance (#27263 )

2023-04-24 13:04:10 +00:00

src

fix(angular): tabs supports conditional slot bindings (#27582 )

2023-06-06 22:41:33 -04:00

test

fix(angular): tabs supports conditional slot bindings (#27582 )

2023-06-06 22:41:33 -04:00

.eslintignore

feat(virtual-scroll): remove virtual scroll component (#25808 )

2022-08-24 15:42:12 -04:00

.eslintrc.json

feat(virtual-scroll): remove virtual scroll component (#25808 )

2022-08-24 15:42:12 -04:00

.prettierignore

chore(): sync with main

2022-09-30 12:27:17 -04:00

CHANGELOG.md

merge release-7.0.10

2023-05-31 14:07:45 -04:00

ng-package.json

feat(angular,angular-server): angular v14 minimum support (#26822 )

2023-02-22 12:33:49 -05:00

package-lock.json

merge release-7.0.10

2023-05-31 14:07:45 -04:00

package.json

merge release-7.0.10

2023-05-31 14:07:45 -04:00

README.md

docs(angular, core): change link from slack to discord (#27519 )

2023-05-19 20:23:36 +00:00

tsconfig.json

refactor(ci): do not cache node modules (#26265 )

2022-11-14 13:55:46 -05:00

tsconfig.schematics.json

feat(): support ng add (#15323 )

2018-11-27 13:36:59 -05:00

tslint.json

feat(angular): build for angular 12.0 (#23970 )

2021-10-15 16:54:59 -04:00

README.md

@ionic/angular

Ionic Angular specific building blocks on top of @ionic/core components.

License

Testing ng-add in ionic

Pull the latest from main
Build ionic/angular: npm run build
Run npm link from ionic/angular/dist directory
Create a blank angular project

ng new add-test
// Say yes to including the router, we need it
cd add-test

To run schematics locally, we need the schematics-cli (once published, this will not be needed)

npm install @angular-devkit/schematics-cli

Link @ionic/angular

npm link @ionic/angular

Run the local copy of the ng-add schematic

$ npx schematics @ionic/angular:ng-add

You'll now be able to add ionic components to a vanilla Angular app setup.

README.md

@ionic/angular

Related

License

Testing ng-add in ionic