Liam DeBeasi ce8393753c test(select, select-popover): migrate to generators (#27393) ...

Issue number: N/A

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

Select and select popover tests are using legacy syntax

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Select and select popover tests are using generator syntax


915bb49fad

- The select custom behavior does not vary across directions, so I
removed the extra RTL checks.


01555bd44b

- The single value screenshots were not being used, so I removed them.


8b4cffcaf8

- The spec screenshots were not being used, so I removed them.


e50b08b2ed

- The legacy standalone check does not vary across directions, so I
removed the RTL checks.


43e26bab77

- The legacy single value tests do not vary across directions, so I
removed the the RTL checks


4935a68aab

- The basic tests were creating screenshots of each overlay as they were
opened. However, we already have test coverage for how each overlay is
rendered in each overlay test suite. As a result, I removed the
screenshots in favor of a `toBeVisible` assertion. This ensures that
overlays are presented with the select, which is what I think we want to
prioritize testing.
- These same tests were also waiting for overlays to dismiss. This
behavior is already tested in the respective overlay test suites, so I
removed the dismiss calls.


8cc6c426f1
- The legacy basic tests were creating screenshots of each overlay as
they were opened. However, we already have test coverage for how each
overlay is rendered in each overlay test suite. As a result, I removed
the screenshots in favor of a `toBeVisible` assertion. This ensures that
overlays are presented with the select, which is what I think we want to
prioritize testing.
- These same tests were also waiting for overlays to dismiss. This
behavior is already tested in the respective overlay test suites, so I
removed the dismiss calls.

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

---------

Co-authored-by: ionitron <hi@ionicframework.com>

2023-05-08 17:27:56 +00:00

..

components

test(select, select-popover): migrate to generators (#27393)

2023-05-08 17:27:56 +00:00

css

chore(): sync with main

2023-03-08 09:35:37 -05:00

global

revert(): revert base components feature (#26692)

2023-01-30 11:52:36 -05:00

themes

fix(item-divider): removal of unneeded margin unset (#27042)

2023-04-04 21:11:51 +00:00

utils

test(utils): migrate to generators (#27383)

2023-05-04 15:49:46 +00:00

components.d.ts

fix(modal, popover): wait for contents to mount (#27344)

2023-05-03 14:32:25 +00:00

index.ts

revert(): revert base components feature (#26692)

2023-01-30 11:52:36 -05:00

interface.d.ts

fix(types): export DatetimeHighlightStyle (#27360)

2023-05-04 19:12:30 +00:00