mirror of
https://github.com/ionic-team/ionic-framework.git
synced 2025-11-10 00:27:41 +08:00
8fa12fc888
Issue number: resolves #27966 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> The large title on iOS added bottom padding to create space between the title and the main content. However, this caused tall text to be cut off on the top. During development I also noticed that the padding value we were using does not match the iOS spec. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - The padding is now applied to the toolbar that contains the large title. The title itself is positioned absolutely so adding padding/margin to it never actually had the desired effect. What we want is space between the title and any content in sibling toolbars. All the padding on the title did was shift content within the title up to give the impression of space between the title and other content. - Adjusted the actual padding values to align with the iOS spec Note: The screenshot diffs here are correct. By adding padding to the toolbar we are increasing the height of the toolbar by 6px. As noted above, we never truly had spacing between the large title and the content since the text inside of the title was just being shifted by 6px to give the impression of spacing. Additionally, the padding values were further adjusted to match the iOS spec: | native | ionic | diff | | - | - | - | |  |  |  | - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev build: `7.2.4-dev.11691683954.1b6ed4bb` --------- Co-authored-by: ionitron <hi@ionicframework.com>