Issue number: resolves #28431
---------
<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->
<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->
## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->
My previous attempt at fixing
https://github.com/ionic-team/ionic-framework/issues/28358 caused inputs
to no longer be correctly proxied to the underlying components. This was
an attempt to work around an underlying ng-packagr bug (see linked
thread for more info).
## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->
I decided it would be best to continue using `ProxyCmp` (since we know
that works) and find an alternative to working around the ng-packagr
bug. I spoke with the Angular team, and they recommended pulling the
provider into its own object. `forwardRef` is now required since we are
referencing the component before it is declared.
- Revert
82d6309ef1
- Moves provider to an object to avoid ng-packagr issue
- I reverted the proxy e2e tests. These are no longer needed since we
are not ejecting from the typical `ProxyCmp` usage anymore.
## Does this introduce a breaking change?
- [ ] Yes
- [x] No
<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->
## Other information
<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->
Dev build: `7.5.3-dev.11698699090.1151d73f`
Verified that the issue is fixed with the repro provided in
https://github.com/ionic-team/ionic-framework/issues/28431
Also verified that this does not regress the issue described in
https://github.com/ionic-team/ionic-framework/issues/28358.
Angular E2E Test Apps
Ionic Framework supports multiple versions of Angular. As a result, we need to verify that Ionic works correctly with each of these Angular versions.
Syncing Local Changes
The Angular test app supports syncing your locally built changes for validation.
- Build the
coreandpackages/angulardirectories usingnpm run build. - Build the Angular test app.
- Navigate to the built test app directory (e.g.
packages/angular/test/build/ng14). - Install dependencies using
npm install. - Sync your local changes using
npm run sync.
From here you can either build the application or start a local dev server. When re-syncing changes, you will need to wipe or disable the application cache.
Application Cache
Angular CLI creates a cache of several files on disk by default in the .angular directory. This decreases the time taken to build the test application. However, the cache makes it difficult to quickly sync and check local changes of Ionic. As a result, the .angular cache is disabled by default in the test app projects.
See https://angular.io/cli/cache for more information.
Disable Cache
ng cache disable
Note
You may need to manually remove the
.angulardirectory once after running this command.
Enable Cache
ng cache enable
Note
You will need to delete the
.angularcache and restart the dev server every time you want to sync local changes of Ionic.
Test App Build Structure
Note
Please confirm your current directory as
packages/angular/testbefore proceeding with any of the following commands.
Unlike other test applications, these test apps are broken up into multiple directories. These directories are then combined to create a single application. This allows us to share common application code, tests, etc so that each app is being tested the same way. Below details the different pieces that help create a single test application.
apps - This directory contains partial applications for each version of Angular we want to test. Typically these directories contain new package.json files, angular.json files, and more. If you have code that is specific to a particular version of Angular, put it in this directory.
base - This directory contains the base application that each test app will use. This is where tests, application logic, and more live. If you have code that needs to be run on every test app, put it in this directory.
build - When the apps and base directories are merged, the final result is put in this directory. The build directory should never be committed to git.
build.sh - This is the script that merges the apps and base directories and places the built application in the build directory.
Usage:
# Build a test app using apps/ng14 as a reference
./build.sh ng14
How to modify test apps
To add new tests, components, or pages, modify the base project. This ensures that tests are run for every tested version.
If you want to add a version-specific change, add the change inside of the appropriate projects in apps. Be sure to replicate the directory structure. For example, if you are adding a new E2E test file called test.spec.ts in apps/ng14, make sure you place the file in apps/ng14/e2e/src/test.spec.ts.
Version-specific tests
If you need to add E2E tests that are only run on a specific version of the JS Framework, replicate the VersionTest component on each partial application. This ensures that tests for framework version X do not get run for framework version Y.
Testing Lazy Loaded Ionic Components
Tests for lazy loaded Ionic UI components should only be added under the /lazy route. This ensures the IonicModule is added.
Testing Standalone Ionic Components
Tests for standalone Ionic UI components should only be added under the /standalone route. This allows for an isolated environment where the lazy loaded IonicModule is not initialized. The standalone components use Stencil's custom element bundle instead of the lazy loaded bundle. If IonicModule is initialized then the Stencil components will fall back to using the lazy loaded implementation instead of the custom elements bundle implementation.
Adding New Test Apps
As we add support for new versions of Angular, we will also need to update this directory to test against new applications. The following steps can serve as a guide for adding new apps:
- Navigate to the built app for the most recent version of Angular that Ionic tests.
- Update the application by following the steps on https://update.angular.io/.
- Make note of any files that changed during the upgrade (
package.json,package-lock.json,angular.json, etc). - Copy the changed files to a new directory in
apps. - Add a new entry to the matrix for
test-core-angularin./github/workflows/build.yml. This will allow the new test app to run against all PRs. - Commit these changes and push.
Example:
In this example, we are going to add the Angular 14 test app.
- Build the Angular 13 test app using
./build.sh ng13. - Navigate to
build/ng13. - Perform the upgrade steps on https://update.angular.io/. The "From" field should say "13.0" and the "To" field should say "14.0".
Note: You may encounter some other peer dependency issues not covered by the Angular Upgrade Guide. These peer dependency issues can be resolved manually by updating the installed version of each dependency.
- Observe that the output of the Angular upgrade indicates that the following files were modified:
angular.json
package-lock.json
package.json
tsconfig.json
src/app/form/form.component.ts
src/app/modal-example/modal-example.component.ts
- Create a directory in
appsnamedng14. - Copy the modified files to the
apps/ng14directory. - Open
./github/workflows/build.ymland find thetest-angular-e2ejob. - Find the
appsfield undermatrix. - Add "ng14" to the
appsfield. - Commit these changes and push.