javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-15 09:34:19 +08:00
Code Issues Packages Projects Releases Wiki Activity
Files
ionic-framework/angular
History
Sean Perkins 9313a914b7 fix(overlays): assign incremental id to overlay host (#27278) 
Issue number: Internal

---------

<!-- Please refer to our contributing documentation for any questions on
submitting a pull request, or let us know here if you need any help:
https://ionicframework.com/docs/building/contributing -->

<!-- Some docs updates need to be made in the `ionic-docs` repo, in a
separate PR. See
https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#modifying-documentation
for details. -->

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

The counter for incrementing the `id` and `z-index` of an overlay is
incremented whenever the `connectedCallback` is fired for an overlay.

When an overlay is presented and/or conditionally rendered, the overlay
`id` can increment by `n+2` instead of `n+1`.

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Increments all overlay ids consistently
- Removes legacy `ion-modal-{id}` and `ion-popover-{id}` logic
- Adds unit tests for the id behavior
- Tests are split up into separate files so that the counter is always
starting from `0`
- Adds an integration test with the Angular test app to verify
conditional rendering behavior

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->
2023-05-03 17:24:19 +00:00
..
scripts
chore(ci): enable npm package provenance (#27263)
2023-04-24 13:04:10 +00:00
src
fix(modal, popover): wait for contents to mount (#27344)
2023-05-03 14:32:25 +00:00
test
fix(overlays): assign incremental id to overlay host (#27278)
2023-05-03 17:24:19 +00:00
.eslintignore
feat(virtual-scroll): remove virtual scroll component (#25808)
2022-08-24 15:42:12 -04:00
.eslintrc.json
feat(virtual-scroll): remove virtual scroll component (#25808)
2022-08-24 15:42:12 -04:00
.prettierignore
chore(): sync with main
2022-09-30 12:27:17 -04:00
CHANGELOG.md
v7.0.5
2023-05-03 12:49:22 +00:00
ng-package.json
feat(angular,angular-server): angular v14 minimum support (#26822)
2023-02-22 12:33:49 -05:00
package-lock.json
chore(): update package lock files
2023-05-03 12:49:38 +00:00
package.json
v7.0.5
2023-05-03 12:49:22 +00:00
README.md
chore(repo): update old heroku app links (#27284)
2023-04-26 15:47:46 +00:00
tsconfig.json
refactor(ci): do not cache node modules (#26265)
2022-11-14 13:55:46 -05:00
tsconfig.schematics.json
feat(): support ng add (#15323)
2018-11-27 13:36:59 -05:00
tslint.json
feat(angular): build for angular 12.0 (#23970)
2021-10-15 16:54:59 -04:00

README.md

@ionic/angular

Ionic Angular specific building blocks on top of @ionic/core components.

Related

License

Testing ng-add in ionic

  1. Pull the latest from main
  2. Build ionic/angular: npm run build
  3. Run npm link from ionic/angular/dist directory
  4. Create a blank angular project
ng new add-test
// Say yes to including the router, we need it
cd add-test
  1. To run schematics locally, we need the schematics-cli (once published, this will not be needed)
npm install @angular-devkit/schematics-cli
  1. Link @ionic/angular
npm link @ionic/angular
  1. Run the local copy of the ng-add schematic
$ npx schematics @ionic/angular:ng-add

You'll now be able to add ionic components to a vanilla Angular app setup.