mirror of
https://github.com/ionic-team/ionic-framework.git
synced 2026-03-13 10:22:08 +08:00
c267b43396
<!-- Please refer to our contributing documentation for any questions on submitting a pull request, or let us know here if you need any help: https://ionicframework.com/docs/building/contributing --> <!-- Some docs updates need to be made in the `ionic-docs` repo, in a separate PR. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#modifying-documentation for details. --> <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Occurs only when using modal with datetime: text does not update appropriately based on light or dark mode. For example, when using Ionic dark theme, the calendar days does not switch to white. <!-- Issues are required for both bug fixes and features. --> Issue URL: resolves #26060 ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Text (days and time) changes to the text color set via light (default) or dark mode. The color change applies to days and time that are not selected: not the current day. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Recommendation: - Test both `datetime` and `datetime-button` The bug originates when modal's content is not wrapped by `ion-content` and because the modal renders outside of `<main />`. Text color is passed to components properly inside `main` because `main` is rendered inside another `ion-content`. `ion-content` provides the correct text-color based on light or dark mode. Example of text color working for modal when wrapped by `ion-content`: ```html <ion-modal trigger="open-modal"> ... <ion-content class="ion-padding"> <div>Hello world</div> </ion-content> </ion-modal> ``` However, there are times that the modal does not require this wrap: ```html <ion-modal> <ion-datetime id="datetime"></ion-datetime> </ion-modal> ``` The same bug would have occurred on `popover` if it wasn't for the fact that the component provides the [text color](https://github.com/ionic-team/ionic-framework/blob/main/core/src/components/popover/popover.scss#L42). --------- Co-authored-by: ionitron <hi@ionicframework.com>