mirror of
https://github.com/ionic-team/ionic-framework.git
synced 2026-02-05 06:27:37 +08:00
bbdb0ca480
<!-- Please refer to our contributing documentation for any questions on submitting a pull request, or let us know here if you need any help: https://ionicframework.com/docs/building/contributing --> <!-- Some docs updates need to be made in the `ionic-docs` repo, in a separate PR. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#modifying-documentation for details. --> <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> <!-- Issues are required for both bug fixes and features. --> Issue URL: resolves https://github.com/ionic-team/ionic-framework/issues/27130 The active/focus background colors on ion-item for iOS are always #000. This allows for the correct contrast on light mode. This is a problem on dark mode because the item background color defaults to #000 as well. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Updates the default active/focus colors to be the text color. This ensures that the active/focus colors are always the opposite of what the default item background color is. ## Does this introduce a breaking change? - [ ] Yes - [x] No Note: We are updating the default values of CSS Variables, but our implementation of the spec is wrong and creates color contrast issues. <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> --------- Co-authored-by: ionitron <hi@ionicframework.com>