javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-06 22:29:44 +08:00
Code Issues Packages Projects Releases Wiki Activity
Files
ionic-framework/core/scripts
History
Liam DeBeasi 15e368c378 feat(theme): improved color contrast with color palette (#28791) 
Issue number: Internal

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

The team would like to ensure that Ionic Framework components that use
an Ionic color (primary, secondary, etc) on top of a contrast color pass
minimum contrast ratios as defined in the WCAG.

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Introduces a revised set of Ionic colors that pass AA color contrast
guidelines when with the appropriate contrast.

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!--
  If this introduces a breaking change:
1. Describe the impact and migration path for existing applications
below.
  2. Update the BREAKING.md file with the breaking change.
3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
See
https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer
for more information.
-->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

---------

Co-authored-by: Sean Perkins <13732623+sean-perkins@users.noreply.github.com>
Co-authored-by: Brandy Carney <brandy@ionic.io>
Co-authored-by: Sean Perkins <sean@ionic.io>
Co-authored-by: Shawn Taylor <shawn@ionic.io>
Co-authored-by: Brandy Carney <brandyscarney@users.noreply.github.com>
Co-authored-by: Amanda Johnston <90629384+amandaejohnston@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: ionitron <hi@ionicframework.com>
2024-01-08 15:30:35 -05:00
..
custom-elements
feat(custom-elements): add experimental custom elements build (#22863)
2021-02-11 12:08:00 -05:00
testing
feat(theme): improved color contrast with color palette (#28791)
2024-01-08 15:30:35 -05:00
api-spec-generator.js
chore(api): update api generator to include parts in the public API (#21110)
2020-04-22 15:41:44 -04:00
clean.js
fix(): update to Stencil One 🎉🎊
2019-06-19 21:33:50 +02:00
readme.md
chore(scripts): rename npm run dev to npm start (#16416)
2018-11-21 10:05:25 -06:00
treeshaking.js
feat(custom-elements): add experimental custom elements build (#22863)
2021-02-11 12:08:00 -05:00
update-readme.js
chore(): update README and script
2018-08-29 18:06:07 +02:00

readme.md

Build

1. Clone ionic

git@github.com:ionic-team/ionic.git
cd ionic

2. Run npm install

cd core npm install

Notice that @ionic/core lives in core.

3. Run npm start

Make sure you are inside the core directory.

npm start

With the dev command, Ionic components will be built with Stencil, changes to source files are watched, a local http server will startup, and http://localhost:3333/ will open in a browser.

4. Preview

Navigate to http://localhost:3333/src/components/. Each component has small e2e apps found in the test directory, for example: http://localhost:3333/src/components/button/test/basic

As changes are made in an editor to source files, the e2e app will live-reload.

How to contribute

  1. npm start allows you to modify the components and have live reloading, just like another ionic app.

  2. When everything looks good, run npm run validate to verify the tests linter and production build passes.

Deploy

  1. npm run prepare.deploy
  2. Review/update changelog
  3. Commit updates using the package name and version number as the commit message.
  4. npm run deploy
  5. 🎉