mirror of https://github.com/ionic-team/ionic-framework.git synced 2026-03-13 10:22:08 +08:00

Files

Brandy Carney ab4f2791c1 fix(vue): pass router-link value to href to properly render clickable elements (#29745 )

Issue number: N/A

---------

## What is the current behavior?
Ionic Framework Vue components using `router-link` do not apply an
`href` property which causes components to render `div` or `button`
elements when they should render an `a`. This is inconsistent with the
way Angular and Vue handle router link.

## What is the new behavior?
Updates `@stencil/vue-output-target` to latest which adds the code from
the following PR:
https://github.com/ionic-team/stencil-ds-output-targets/pull/446

The update in vue output target checks if `router-link` and `navManager`
are defined so this fix only applies to Ionic Framework components. If
both are defined then it adds the `href` property to the element with
the value of `router-link`.

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

## Other information

Dev build: `8.2.7-dev.11722629362.1ac136c4`

2024-08-05 21:35:26 +00:00

scripts

fix(vue): pass router-link value to href to properly render clickable elements (#29745 )

2024-08-05 21:35:26 +00:00

src

fix(vue): pass router-link value to href to properly render clickable elements (#29745 )

2024-08-05 21:35:26 +00:00

test

fix(vue): pass router-link value to href to properly render clickable elements (#29745 )

2024-08-05 21:35:26 +00:00

types

feat(slides): remove ion-slide, ion-slides, and IonicSwiper module (#25868 )

2022-09-01 14:36:17 -05:00

.eslintignore

chore(vue): add eslint and prettier (#26635 )

2023-01-18 18:29:25 -05:00

.eslintrc.js

chore(vue): add eslint and prettier (#26635 )

2023-01-18 18:29:25 -05:00

.prettierignore

chore(vue): add eslint and prettier (#26635 )

2023-01-18 18:29:25 -05:00

CHANGELOG.md

merge release-8.2.6 (#29730 )

2024-07-24 16:23:11 -04:00

package-lock.json

merge release-8.2.6 (#29730 )

2024-07-24 16:23:11 -04:00

package.json

merge release-8.2.6 (#29730 )

2024-07-24 16:23:11 -04:00

README.md

docs(many): update Contributing links (#29498 )

2024-05-14 19:48:36 +00:00

rollup.config.mjs

refactor: update to rollup 4 (#28459 )

2023-11-07 15:21:46 +00:00

tsconfig.json

chore: packages do not explicitly run tsc (#28450 )

2023-11-06 19:23:48 +00:00

README.md

@ionic/vue

Ionic Framework integration for Vue 3 apps.

Building

Install dependencies in @ionic/core:

cd core && npm install

Build @ionic/core. This will generate Vue component bindings in the packages/vue directory:

npm run build

Install dependencies in @ionic/vue:

cd packages/vue && npm install

Build @ionic/vue:

npm run build

Install dependencies in @ionic/vue-router:

cd packages/vue-router && npm install

Build @ionic/vue-router:

npm run build

Tests

E2E Tests are found in the packages/vue/test/base/tests directory and use Cypress.
When making changes to @ionic/vue or @ionic/vue-router you can run npm run sync in the test-app directory to ensure that the test application is using your built changes. Be sure to build in the vue and vue-router directories first.
Tests can be run in headless mode by running npm run cypress.
If you want to open the Cypress test runner, you can run node_modules/.bin/cypress open.
Bug fix and feature PRs should have new tests verifying the PR functionality.

Contributing

See our Contributing Guide.

Need Help?

Post your question on the Ionic Forum.