mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-15 01:03:03 +08:00

Files

Sean Perkins 3e191df3dd fix(react): onDoubleClick fires on components (#27611 )

Issue number: Resolves #21320

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

`onDoubleClick` bindings on Ionic components do not fire when the
element is double clicked.

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- `onDoubleClick` fires on Ionic components
- Fixed the unit testing set-up for the react test apps

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

2023-06-08 18:35:25 +00:00

public

test(react): migrate to builder architecture (#26959 )

2023-03-17 16:21:21 -04:00

scripts

chore: sync script deletes existing tgz packages (#27045 )

2023-04-05 20:13:43 +00:00

src

fix(react): onDoubleClick fires on components (#27611 )

2023-06-08 18:35:25 +00:00

tests/e2e

fix(react, vue): inline modals apply ion-page class (#27481 )

2023-05-24 13:37:02 +00:00

.gitignore

test(react): migrate to builder architecture (#26959 )

2023-03-17 16:21:21 -04:00

cypress.config.ts

test(react): migrate to builder architecture (#26959 )

2023-03-17 16:21:21 -04:00

ionic.config.json

test(react): migrate to builder architecture (#26959 )

2023-03-17 16:21:21 -04:00

README.md

test(react): migrate to builder architecture (#26959 )

2023-03-17 16:21:21 -04:00

tsconfig.json

test(react): migrate to builder architecture (#26959 )

2023-03-17 16:21:21 -04:00

README.md

React Test App

Getting Started

Setup

Make sure you are using the latest versions of node and npm. If you do not have these, download the installer for the LTS version of Node.js. This is the best way to also install npm.

Building Dependencies

Navigate to the core, packages/react and packages/react-router directories and build each of them:

npm i
npm run build

Then, install dependencies from this directory for this test app:

npm i

Syncing Changes

When making changes to the React package, run the following from this directory to sync the changes:

npm run sync

Previewing App

To preview this app locally, run the following from this directory:

npm start

Running Tests

To run the e2e tests, run the following from this directory:

npm run build
npm run e2e