ionic-framework

mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-15 01:03:03 +08:00

Files

Sean Perkins c8d214a82c chore(vue): add missing routerAnimation type (#28094 )

Issue number: N/A

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

The Vue Router implementation [assigns data to the `routerAnimation` on
the view
item](cddefd1548/packages/vue/src/components/IonRouterOutlet.ts (L165-L170)),
but the [type does not exist on the `ViewItem`
interface](https://github.com/ionic-team/ionic-framework/blob/main/packages/vue-router/src/types.ts#L62-L76).
The actual routing implementation does not make use of the type, but
this is backfilling the information when we wire up the types to the
implementation.

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Adds the missing type for `routerAnimation` to the `ViewItem`

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

2023-08-31 16:45:06 +00:00

index.ts

chore(vue-router): add eslint and prettier (#26636 )

2023-01-19 08:51:08 -05:00

locationHistory.ts

chore(vue-router): add eslint and prettier (#26636 )

2023-01-19 08:51:08 -05:00

router.ts

fix(react, vue): custom animations are used when going back (#27895 )

2023-07-31 17:57:03 +00:00

types.ts

chore(vue): add missing routerAnimation type (#28094 )