mirror of
https://github.com/ionic-team/ionic-framework.git
synced 2025-11-04 03:48:13 +08:00
60303aad23
Issue number: resolves #28611 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> It's not possible to pass props that are not camelCase to the `IonNav` component. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - It is now possible to set a props with kebab-case instead of camelCase (for example, `root-params` instead of `rootParams`) ## Does this introduce a breaking change? - [ ] Yes - [X] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> ⚠️ This is my first PR for ionic so I hope I didn't miss important steps into the process. I also checked on my project that the fix is working well. Thank you! 🙂 --------- Co-authored-by: Sean Perkins <sean@ionic.io>
20 lines
476 B
JavaScript
20 lines
476 B
JavaScript
describe('Navigation', () => {
|
|
beforeEach(() => {
|
|
cy.visit('/navigation');
|
|
});
|
|
|
|
it('should push a page with props', () => {
|
|
cy.get('#open-nav-modal').click();
|
|
|
|
cy.get('#push-nav-child').click();
|
|
|
|
cy.get('#nav-child-content').should('have.text', 'Custom Title');
|
|
});
|
|
|
|
it('nav should support kebab-case root-params', () => {
|
|
cy.get('#open-nav-modal').click();
|
|
|
|
cy.get('#nav-root-params').should('have.text', 'Message: Hello World!');
|
|
});
|
|
});
|