mirror of
https://github.com/ionic-team/ionic-framework.git
synced 2025-08-15 09:34:19 +08:00
824033f1d4
Issue number: resolves #27873 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Custom animations are not always used when the `handleNavigateBack` method is called. This impacts both Ionic React and Ionic Vue. While we do set the `incomingRouteParams` with the animation:a08a5894ba/packages/react-router/src/ReactRouter/IonRouter.tsx (L247-L252)We do sometimes call `handleNavigate`:a08a5894ba/packages/react-router/src/ReactRouter/IonRouter.tsx (L273-L279)This `handleNavigate` method sets `incomingRouteParams` again:a08a5894ba/packages/react-router/src/ReactRouter/IonRouter.tsx (L225-L230)Since we do not re-pass `routeAnimation`, that field gets set to `undefined` and the custom animation does not get used. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Custom animation is now passed to `handleNavigate` ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev build: `7.2.2-dev.11690810887.180000d1`