ionic-framework

mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-09 08:09:32 +08:00

Files

Liam DeBeasi 9500769f11 fix(nav): improve reliability of swipe back gesture when quickly swiping back (#27904 )

Issue number: resolves #27893

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

This is another instance of
https://github.com/ionic-team/ionic-framework/issues/22895. The
`progressCallback` function is fires asynchronously, so it's possible
for the gesture start and end callbacks to run before the animation is
ever set in `progressCallback`. When this happens, the animation gets
locked up.

I previously fixed this in
https://github.com/ionic-team/ionic-framework/pull/23527 for
`ion-router-outlet`, but I did not fix it for `ion-nav`.

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- If the gesture has ended by the time `progressCallback` fires, reset
the animation to the beginning so it does not get locked up.

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

Dev build: `7.2.2-dev.11690896715.12338339`

2023-08-02 18:48:34 +00:00

test

test(nav): migrate to generators (#27332 )

2023-04-28 17:02:31 +00:00

constants.ts

refactor(all): avoid using export const enum (#16614 )

2018-12-06 21:19:49 +01:00

nav-interface.ts

chore(deps): update to stencil v3 (#26663 )

2023-01-31 18:07:22 -05:00

nav.scss

fix(angular): add swipe-to-go-back gesture