javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-15 09:34:19 +08:00
Code Issues Packages Projects Releases Wiki Activity
Files
ionic-framework/packages/angular
History
Liam DeBeasi 9453132aa8 fix(angular): overlays are defined when using standalone controllers (#28560) 
Issue number: resolves #28385

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

Overlay controllers do not register their respective overlays
components. This results in the overlay not appearing.

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Each standalone overlay controller manually calls
`defineCustomElement` for their respective overlay component to ensure
the component is loaded/registered.

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->


Dev build: `7.5.6-dev.11700492285.1581ed02`
2023-11-20 22:45:51 +00:00
..
common
refactor(angular): loading controller uses correct core instance (#28543)
2023-11-17 21:16:56 +00:00
scripts
refactor(angular): move to packages directory (#27719)
2023-07-05 17:52:35 +00:00
src
fix(angular): ng add @ionic/angular in standalone projects (#28523)
2023-11-20 22:20:20 +00:00
standalone
fix(angular): overlays are defined when using standalone controllers (#28560)
2023-11-20 22:45:51 +00:00
test
refactor(angular): loading controller uses correct core instance (#28543)
2023-11-17 21:16:56 +00:00
.eslintignore
refactor(angular): move to packages directory (#27719)
2023-07-05 17:52:35 +00:00
.eslintrc.json
refactor(angular): move to packages directory (#27719)
2023-07-05 17:52:35 +00:00
.prettierignore
fix(angular): standalone form components do not error when multiple are used (#28423)
2023-10-27 19:08:54 +00:00
CHANGELOG.md
v7.5.5
2023-11-15 15:27:28 +00:00
ng-package.json
refactor(angular): move to packages directory (#27719)
2023-07-05 17:52:35 +00:00
package-lock.json
fix(angular): ng add @ionic/angular in standalone projects (#28523)
2023-11-20 22:20:20 +00:00
package.json
fix(angular): ng add @ionic/angular in standalone projects (#28523)
2023-11-20 22:20:20 +00:00
README.md
feat(angular): ship Ionic components as Angular standalone components (#28311)
2023-10-10 13:06:23 -04:00
tsconfig.json
chore(angular): type checking for standalone directory (#28531)
2023-11-15 18:58:27 +00:00
tsconfig.schematics.json
refactor(angular): move to packages directory (#27719)
2023-07-05 17:52:35 +00:00

README.md

@ionic/angular

Ionic Angular specific building blocks on top of @ionic/core components.

Related

License

Testing ng-add in ionic

  1. Pull the latest from main
  2. Build ionic/angular: npm run build
  3. Run npm link from ionic/angular/dist directory
  4. Create a blank angular project
ng new add-test
// Say yes to including the router, we need it
cd add-test
  1. To run schematics locally, we need the schematics-cli (once published, this will not be needed)
npm install @angular-devkit/schematics-cli
  1. Link @ionic/angular
npm link @ionic/angular
  1. Run the local copy of the ng-add schematic
$ npx schematics @ionic/angular:ng-add

You'll now be able to add ionic components to a vanilla Angular app setup.

Project Structure

common

This is where logic that is shared between lazy loaded and standalone components live. For example, the lazy loaded IonPopover and standalone IonPopover components extend from a base IonPopover implementation that exists in this directory.

Note: This directory exposes internal APIs and is only accessed in the standalone and src submodules. Ionic developers should never import directly from @ionic/angular/common. Instead, they should import from @ionic/angular or @ionic/angular/standalone.

standalone

This is where the standalone component implementations live. It was added as a separate entry point to avoid any lazy loaded logic from accidentally being pulled in to the final build. Having a separate directory allows the lazy loaded implementation to remain accessible from @ionic/angular for backwards compatibility.

Ionic developers can access this by importing from @ionic/angular/standalone.

src

This is where the lazy loaded component implementations live.

Ionic developers can access this by importing from @ionic/angular.