mirror of https://github.com/ionic-team/ionic-framework.git synced 2026-03-13 10:22:08 +08:00

Files

Liam DeBeasi 91d0e267b2 feat(picker-column): add styles, disabled and active states (#28621 )

Issue number: Internal

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

We'd like to introduce a new API to the picker column to allow
developers to manipulate the picker options right in the DOM. Currently
developers need to pass an object which is quite cumbersome as you need
to re-pass that object anytime you want to change a single option.

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

This PR does some of the prep work to make integrating the picker column
option into picker column easier. It does the following things:

1. Copies the base button styles from picker-column over to
picker-column-option
2. Creates active and disabled states (plus styles)
3. Add tests for base styles

Note: There are duplicate styles across picker-column and
picker-column-option that will be cleaned up once picker-column-option
is integrated and shown to be functional.

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

---------

Co-authored-by: ionitron <hi@ionicframework.com>

2023-12-05 14:40:53 -05:00

scripts

refactor(picker): deprecate ion-picker and ion-picker-column (#28584 )

2023-11-28 12:47:37 -05:00

src

feat(picker-column): add styles, disabled and active states (#28621 )

2023-12-05 14:40:53 -05:00

test

test: update test apps to cypress 13 (#28212 )

2023-09-21 20:17:46 +00:00

types

feat(slides): remove ion-slide, ion-slides, and IonicSwiper module (#25868 )

2022-09-01 14:36:17 -05:00

.eslintignore

chore(vue): add eslint and prettier (#26635 )

2023-01-18 18:29:25 -05:00

.eslintrc.js

chore(vue): add eslint and prettier (#26635 )

2023-01-18 18:29:25 -05:00

.prettierignore

chore(vue): add eslint and prettier (#26635 )

2023-01-18 18:29:25 -05:00

CHANGELOG.md

v7.5.6

2023-11-21 14:31:40 +00:00

package-lock.json

chore(): update package lock files

2023-11-21 14:31:53 +00:00

package.json

v7.5.6

2023-11-21 14:31:40 +00:00

README.md

docs(vue): update README instructions (#28175 )

2023-09-14 16:20:51 +00:00

rollup.config.mjs

refactor: update to rollup 4 (#28459 )

2023-11-07 15:21:46 +00:00

tsconfig.json

chore: packages do not explicitly run tsc (#28450 )

2023-11-06 19:23:48 +00:00

README.md

@ionic/vue

Ionic Framework integration for Vue 3 apps.

Building

Install dependencies in @ionic/core:

cd core && npm install

Build @ionic/core. This will generate Vue component bindings in the packages/vue directory:

npm run build

Install dependencies in @ionic/vue:

cd packages/vue && npm install

Build @ionic/vue:

npm run build

Install dependencies in @ionic/vue-router:

cd packages/vue-router && npm install

Build @ionic/vue-router:

npm run build

Tests

E2E Tests are found in the packages/vue/test/base/tests directory and use Cypress.
When making changes to @ionic/vue or @ionic/vue-router you can run npm run sync in the test-app directory to ensure that the test application is using your built changes. Be sure to build in the vue and vue-router directories first.
Tests can be run in headless mode by running npm run cypress.
If you want to open the Cypress test runner, you can run node_modules/.bin/cypress open.
Bug fix and feature PRs should have new tests verifying the PR functionality.

Contributing

See our Contributing Guide.

Need Help?

Post your question on the Ionic Forum.