ionic-framework

mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-09 08:09:32 +08:00

Files

Maria Hutt 23763abf79 fix(header): use aria attributes to hide small title when collapsed (#30027 )

Issue number: resolves #29347 

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

Focusable elements like buttons cannot be accessed within the
`ion-header` when it's collapsed. They're only accessible once the small
title is displayed.

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Moved the `aria-hidden` from the header to `ion-title`, this aligns
with native.
- Updated existing test.

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!--
  If this introduces a breaking change:
1. Describe the impact and migration path for existing applications
below.
  2. Update the BREAKING.md file with the breaking change.
3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
See
https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer
for more information.
-->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

Dev build: `8.4.1-dev.11732064156.12837790`

2024-11-21 18:57:25 +00:00

test

fix(header): use aria attributes to hide small title when collapsed (#30027 )

2024-11-21 18:57:25 +00:00

header.ios.scss

fix(header): iOS headers in MD app are not hidden (#29164 )

2024-03-15 16:03:42 +00:00

header.ios.vars.scss

chore(theming): remove Sass default flags (#29401 )

2024-04-25 19:59:10 +00:00

header.md.scss

fix(header, footer): resolve CSP violations with box shadow (#27560 )