mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-19 11:41:20 +08:00

Files

Liam DeBeasi cd5c099dd3 feat(picker): add inline picker (#28689 )

Issue number: resolves #24905, resolves #26840, resolves #15710

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

The current picker is only displayed as an overlay which makes it
impossible to use inline with the rest of the application. Additionally,
there are several bugs and missing features. For example, it is
impossible to know when the value of the picker column has changed using
public APIs. This is valuable for updating other columns in response to
that data.

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Introduces `ion-picker` as an inline wheel picker component. The
overlay picker is still available using `ion-picker-legacy`.
- The implementation of this component resolves linked bugs. It also
resolves linked features by exposing an `ionChange` event for developers
to listen for.

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

Dev-build: `7.5.8-dev.11702398696.1ab62ea9`

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Shawn Taylor <shawn@ionic.io>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: Amanda Johnston <90629384+amandaejohnston@users.noreply.github.com>
Co-authored-by: Sean Perkins <13732623+sean-perkins@users.noreply.github.com>
Co-authored-by: Brandy Carney <brandyscarney@users.noreply.github.com>

2023-12-13 13:03:58 -05:00

public

test(react): migrate to builder architecture (#26959 )

2023-03-17 16:21:21 -04:00

scripts

chore: sync script deletes existing tgz packages (#27045 )

2023-04-05 20:13:43 +00:00

src

feat(picker): add inline picker (#28689 )

2023-12-13 13:03:58 -05:00

tests/e2e

feat(picker): add inline picker (#28689 )

2023-12-13 13:03:58 -05:00

.gitignore

test(react): migrate to builder architecture (#26959 )

2023-03-17 16:21:21 -04:00

cypress.config.ts

test(react): migrate to builder architecture (#26959 )

2023-03-17 16:21:21 -04:00

ionic.config.json

test(react): migrate to builder architecture (#26959 )

2023-03-17 16:21:21 -04:00

README.md

test(react): migrate to builder architecture (#26959 )

2023-03-17 16:21:21 -04:00

tsconfig.json

test(react): migrate to builder architecture (#26959 )

2023-03-17 16:21:21 -04:00

README.md

React Test App

Getting Started

Setup

Make sure you are using the latest versions of node and npm. If you do not have these, download the installer for the LTS version of Node.js. This is the best way to also install npm.

Building Dependencies

Navigate to the core, packages/react and packages/react-router directories and build each of them:

npm i
npm run build

Then, install dependencies from this directory for this test app:

npm i

Syncing Changes

When making changes to the React package, run the following from this directory to sync the changes:

npm run sync

Previewing App

To preview this app locally, run the following from this directory:

npm start

Running Tests

To run the e2e tests, run the following from this directory:

npm run build
npm run e2e