javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-09 08:09:32 +08:00
Code Issues Packages Projects Releases Wiki Activity
Files
ionic-framework/core/src/components
History
Brandy Carney 5ce4ec0439 feat(action-sheet): add htmlAttributes property for passing attributes to buttons (#27863) 
Issue number: N/A

---------

## What is the current behavior?
Buttons containing only icons are not accessible as there is no way to
pass an `aria-label` attribute (or any other html attribute).

## What is the new behavior?
- Adds the `htmlAttributes` property on the `ActionSheetButton`
interface
- Passes the `htmlAttributes` to the buttons (both the buttons array and
the cancelButton)
- Adds two tests to verify `aria-label` and `aria-labelled-by` are
passed to a button with and without the cancel role - this was done
because action sheet breaks these buttons up when rendering

## Does this introduce a breaking change?

- [ ] Yes
- [x] No
2023-07-31 12:23:46 -04:00
..
accordion
chore(): sync with main
2023-06-20 10:05:00 -04:00
accordion-group
Merge remote-tracking branch 'origin/main' into sp/sync-feature-7.1-with-main
2023-06-01 12:10:45 -04:00
action-sheet
feat(action-sheet): add htmlAttributes property for passing attributes to buttons (#27863)
2023-07-31 12:23:46 -04:00
alert
Merge remote-tracking branch 'origin/main' into sp/sync-feature-7.1-with-main
2023-06-01 12:10:45 -04:00
app
chore(): sync with main
2023-06-20 10:05:00 -04:00
avatar
fix(header, footer): resolve CSP violations with box shadow (#27560)
2023-06-06 23:44:59 +00:00
back-button
fix(back-button): show correct background on focus + hover with ios (#27723)
2023-07-06 16:00:48 +00:00
backdrop
refactor(many): use utils import (#27160)
2023-04-12 13:25:14 -07:00
badge
chore(): sync with main
2023-06-20 10:05:00 -04:00
breadcrumb
Merge remote-tracking branch 'origin/main' into chore/sync-with-main-5-3
2023-05-03 13:38:03 -04:00
breadcrumbs
chore(): sync with main
2023-06-20 10:05:00 -04:00
button
Merge remote-tracking branch 'origin/main' into final-7.2-sync
2023-07-19 09:52:12 -04:00
buttons
feat(button): allow button to increase in height when text wraps (#27547)
2023-07-07 15:04:52 -04:00
card
Merge remote-tracking branch 'origin/main' into sp/sync-feature-7.1-with-main
2023-06-01 12:10:45 -04:00
card-content
…
card-header
chore(): sync with main
2023-06-20 10:05:00 -04:00
card-subtitle
refactor(many): use utils import (#27160)
2023-04-12 13:25:14 -07:00
card-title
refactor(many): use utils import (#27160)
2023-04-12 13:25:14 -07:00
checkbox
fix(radio, checkbox, toggle): add top and bottom margins when in ion-item (#27788)
2023-07-12 20:10:35 +00:00
chip
chore: sync with main
2023-05-16 10:26:41 -04:00
col
refactor(many): use utils import (#27160)
2023-04-12 13:25:14 -07:00
content
chore(): sync with main
2023-06-20 10:05:00 -04:00
datetime
chore(): sync with main
2023-06-20 10:05:00 -04:00
datetime-button
chore: sync with main
2023-05-16 10:26:41 -04:00
fab
chore(deps-dev): Bump @playwright/test from 1.35.1 to 1.36.0 in /core (#27778)
2023-07-12 19:01:21 +00:00
fab-button
Merge remote-tracking branch 'origin/main' into chore/sync-with-main-5-3
2023-05-03 13:38:03 -04:00
fab-list
…
footer
chore(): sync with main
2023-06-20 10:05:00 -04:00
grid
fix(header, footer): resolve CSP violations with box shadow (#27560)
2023-06-06 23:44:59 +00:00
header
chore(): sync with main
2023-06-20 10:05:00 -04:00
icon/test
chore(deps-dev): Bump @playwright/test from 1.33.0 to 1.34.1 in /core (#27533)
2023-05-30 18:22:00 +00:00
img
Merge remote-tracking branch 'origin/main' into chore/sync-with-main-5-3
2023-05-03 13:38:03 -04:00
infinite-scroll
Merge remote-tracking branch 'origin/main' into chore/sync-with-main-5-3
2023-05-03 13:38:03 -04:00
infinite-scroll-content
refactor(many): use utils import (#27160)
2023-04-12 13:25:14 -07:00
input
docs(input, textarea): clarify ionInput and ionChange (#27710)
2023-06-28 15:26:37 +00:00
item
Merge remote-tracking branch 'origin/main' into sp/sync-7.2-with-main-7-12
2023-07-12 22:09:54 -04:00
item-divider
chore(): sync with main
2023-06-20 10:05:00 -04:00
item-group
…
item-option
refactor(many): use utils import (#27160)
2023-04-12 13:25:14 -07:00
item-options
refactor(many): use utils import (#27160)
2023-04-12 13:25:14 -07:00
item-sliding
test(item-sliding): update visual regressions (#27695)
2023-06-26 15:20:38 +00:00
label
chore(): sync with main
2023-06-20 10:05:00 -04:00
list
fix(header, footer): resolve CSP violations with box shadow (#27560)
2023-06-06 23:44:59 +00:00
list-header
Merge remote-tracking branch 'origin/main' into sp/sync-7.2-with-main-7-12
2023-07-12 22:09:54 -04:00
loading
Merge remote-tracking branch 'origin/main' into sp/sync-feature-7.1-with-main
2023-06-01 12:10:45 -04:00
menu
fix(angular): menu button is enabled with Angular Universal builds (#27814)
2023-07-18 15:50:11 +00:00
menu-button
Merge remote-tracking branch 'origin/main' into chore/sync-with-main-5-3
2023-05-03 13:38:03 -04:00
menu-toggle
Merge remote-tracking branch 'origin/main' into chore/sync-with-main-5-3
2023-05-03 13:38:03 -04:00
modal
refactor: use capacitor types for native plugins (#27755)
2023-07-14 15:27:28 +00:00
nav
fix(nav): root component is mounted with root params (#27676)
2023-06-28 15:27:25 +00:00
nav-link
chore(deps): update to stencil v3 (#26663)
2023-01-31 18:07:22 -05:00
note
Merge remote-tracking branch 'origin/main' into chore/sync-with-main-5-3
2023-05-03 13:38:03 -04:00
picker
Merge remote-tracking branch 'origin/main' into sp/sync-feature-7.1-with-main
2023-06-01 12:10:45 -04:00
picker-column
Merge remote-tracking branch 'origin/main' into sp/sync-feature-7.1-with-main
2023-06-01 12:10:45 -04:00
picker-column-internal
feat(datetime): add shadow parts and CSS variables for styling wheel pickers (#27529)
2023-06-06 11:25:15 -05:00
picker-internal
test(picker-internal): re-enable basic screenshot test (#27768)
2023-07-10 18:42:49 +00:00
popover
Merge remote-tracking branch 'origin/main' into sp/sync-7.2-with-main-7-12
2023-07-12 22:09:54 -04:00
progress-bar
chore(): sync with main
2023-06-20 10:05:00 -04:00
radio
fix(radio, checkbox, toggle): add top and bottom margins when in ion-item (#27788)
2023-07-12 20:10:35 +00:00
radio-group
chore(): sync with main
2023-06-20 10:05:00 -04:00
range
chore(): sync with main
2023-06-20 10:05:00 -04:00
refresher
refactor: use capacitor types for native plugins (#27755)
2023-07-14 15:27:28 +00:00
refresher-content
refactor(many): use utils import (#27160)
2023-04-12 13:25:14 -07:00
reorder
fix(many): add aria-hidden to decorative icons (#26922)
2023-03-07 11:57:18 -05:00
reorder-group
Merge remote-tracking branch 'origin/main' into chore/sync-with-main-6
2023-05-05 13:30:21 -05:00
ripple-effect
test(ripple-effect): migrate to generators (#27391)
2023-05-04 16:36:31 +00:00
route
…
route-redirect
…
router
Merge remote-tracking branch 'origin/main' into chore/sync-with-main-6
2023-05-05 13:30:21 -05:00
router-link
refactor(many): use utils import (#27160)
2023-04-12 13:25:14 -07:00
router-outlet
Merge remote-tracking branch 'origin/main' into chore/sync-with-main-6
2023-05-05 13:30:21 -05:00
row
…
searchbar
feat(searchbar): add name property (#27737)
2023-07-17 11:43:00 -04:00
segment
chore(): add updated snapshots
2023-06-20 14:30:36 +00:00
segment-button
feat(segment): display segment as a grid and add an ellipsis to overflowing text in a segment button (#27457)
2023-05-24 11:42:57 -04:00
select
refactor(select): use border mixin (#27732)
2023-07-05 12:49:06 +00:00
select-option
…
select-popover
chore(): sync with main
2023-05-11 14:57:44 -04:00
skeleton-text
chore(): sync with main
2023-06-20 10:05:00 -04:00
slides
chore(): sync with main
2023-03-15 10:03:38 -04:00
spinner
chore(): sync with main
2023-06-20 10:05:00 -04:00
split-pane
fix(header, footer): resolve CSP violations with box shadow (#27560)
2023-06-06 23:44:59 +00:00
tab
refactor(many): use utils import (#27160)
2023-04-12 13:25:14 -07:00
tab-bar
Merge remote-tracking branch 'origin/main' into sp/sync-feature-7.1-with-main
2023-06-01 12:10:45 -04:00
tab-button
test(tab-button): add focus state screenshots (#27731)
2023-07-06 16:03:12 +00:00
tabs
test(tabs, tab-bar, tab-button): migrate to generators (#27356)
2023-05-03 15:51:48 +00:00
text
Merge remote-tracking branch 'origin/main' into chore/sync-with-main-6
2023-05-05 13:30:21 -05:00
textarea
fix(textarea): stacked/floating textarea size is correct on safari (#27766)
2023-07-12 20:35:36 +00:00
thumbnail
test(thumbnail): migrate to generators (#27381)
2023-05-04 00:06:41 +00:00
title
Merge remote-tracking branch 'origin/main' into chore/sync-with-main-6
2023-05-05 13:30:21 -05:00
toast
feat(toast): add htmlAttributes property for passing attributes to buttons (#27855)
2023-07-31 11:07:00 -04:00
toggle
chore(toggle): rename item test to use correct component name (#27789)
2023-07-13 14:56:28 +00:00
toolbar
Merge remote-tracking branch 'origin/main' into sp/sync-feature-7.1-with-main
2023-06-01 12:10:45 -04:00