mirror of
https://github.com/ionic-team/ionic-framework.git
synced 2026-03-13 10:22:08 +08:00
dd6af31cc0
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> There were several redundant tests I missed during the initial generator pass. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. -->b8a3df049e- Moved the `htmlAttributes` e2e test to a spec testfb3f96840c- Removed the HTML content screenshot test. HTML content is already tested in `test/loading.spec.ts`.fc7c166e0e- Removed the per-direction checks on the non-basic tests as these behaviors do not vary across directions. The basic test still has per-direction checks - Also removed the per-mode check on the translucent test since this feature is available on iOS only8524b6c9d6- The isOpen tests are testing that you can open/close the modal by triggering the `isOpen` property. I combined the two tests into 1 test since they are doing the same thing: Checking that the modal opens when `isOpen` is `true` and closes when `isOpen` is false. This also avoids the 500ms timeout of the 2nd test which should speed up execution.f6dac8b47c- Removed the "standalone" screenshot in favor of just checking that the overlay is visible. Rendering of the contents of the overlay are not dependent on `ion-app` being present.a2d6289101- The `runVisualTests` util in `test/basic` was checking that every loading instance could also dismiss. This is only needed for the basic test, so I removed this logic from the shared util and add it just to the basic test. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->