mirror of
https://github.com/ionic-team/ionic-framework.git
synced 2025-11-10 00:27:41 +08:00
995a848575
Issue number: resolves #27184 --------- ## What is the current behavior? The modern form controls do not use the same opacity for their labels when disabled, resulting in inconsistent UI when using two different types in the same view (select vs checkbox, for example). ## What is the new behavior? The checkbox, input, radio, range, select, textarea and toggle labels have been updated on both modes to use the same opacity as each other when disabled. The checkbox and radio icons have been updated to use a different opacity than the label for `md` mode. - Updates `ios` mode so all form controls use the same opacity of `0.3` - I could not find any guidelines by Apple for what color these should be, so I decided to just make them the same as what is most commonly used & match item - Updates `md` mode so all form control labels use the same opacity of `0.38` - I used the [Material Design 3 documentation](https://m2.material.io/components) to get this number as well as the opacity of the disabled selection controls in the [Material Design 2 figma design kit](https://www.figma.com/community/file/778763161265841481). The Material Design 2 documentation does not mention the opacity, but this is also the number used by Material Design 1 so it's safe to assume it is what the disabled form labels should also use for Material Design 2. - Updates the `md` range so the slotted elements are also included when setting the opacity on the label - Updates the range, radio & checkbox tests to make sure there are screenshots in the different disabled states - Updates the item/disabled test to include radio & textarea so you can see all form controls side by side ## Does this introduce a breaking change? - [ ] Yes - [x] No ## Other information I downloaded screenshots of the item disabled tests and put them side by side for `main` and this branch in order to see the differences in the labels. The grey boxes to the left of each item are just a bigger version of the label color for that item, so it's easier to see when they aren't the same.   --------- Co-authored-by: ionitron <hi@ionicframework.com>
56 lines
1.4 KiB
SCSS
56 lines
1.4 KiB
SCSS
@import "./select";
|
|
@import "./select.ios.vars";
|
|
|
|
// iOS Select
|
|
// --------------------------------------------------
|
|
|
|
// TODO FW-3194 - Remove this
|
|
:host(.legacy-select) {
|
|
--padding-top: #{$select-ios-padding-top};
|
|
--padding-end: #{$select-ios-padding-end};
|
|
--padding-bottom: #{$select-ios-padding-bottom};
|
|
--padding-start: #{$select-ios-padding-start};
|
|
}
|
|
|
|
// TODO FW-3194 - Move this to host
|
|
:host(:not(.legacy-select)) {
|
|
min-height: 44px;
|
|
}
|
|
|
|
/**
|
|
* Since the label sits on top of the element,
|
|
* the component needs to be taller otherwise the
|
|
* label will appear too close to the select text.
|
|
*/
|
|
:host(.select-label-placement-floating),
|
|
:host(.select-label-placement-stacked) {
|
|
min-height: 56px;
|
|
}
|
|
|
|
.select-icon {
|
|
width: $select-ios-icon-size;
|
|
height: $select-ios-icon-size;
|
|
|
|
// Color deviates from the iOS spec, but satisfies WCAG AAA:
|
|
// https://www.w3.org/TR/WCAG20-TECHS/G18.html
|
|
color: #{$text-color-step-350};
|
|
}
|
|
|
|
// Select Native Wrapper
|
|
// ----------------------------------------------------------------
|
|
|
|
:host(.select-label-placement-stacked) .native-wrapper,
|
|
:host(.select-label-placement-floating) .native-wrapper {
|
|
width: calc(100% - $select-ios-icon-size - $select-icon-margin-start);
|
|
}
|
|
|
|
// Select: Disabled
|
|
// ----------------------------------------------------------------
|
|
// The select and label should use the
|
|
// same opacity and match the other form
|
|
// controls
|
|
|
|
:host(.select-disabled) {
|
|
opacity: $select-ios-disabled-opacity;
|
|
}
|