mirror of
https://github.com/ionic-team/ionic-framework.git
synced 2026-03-13 10:22:08 +08:00
4c9083050b
Issue number: internal
---------
This does a couple things:
**1 - Adds a `sync` command to get the latest `core` build in
`angular-server`**
The release process for `angular-server` failed
[here](https://github.com/ionic-team/ionic-framework/actions/runs/9686982182/job/26730689874).
This failure was only made apparent because the Lerna command
[here](52ff0505e8/.github/workflows/actions/publish-npm/action.yml (L35))
runs prior to building each package.
This should have been caught by CI on the [update to @stencil/core to
v4.19.0](https://github.com/ionic-team/ionic-framework/pull/29666), but
the `angular-server` package is the only package that doesn't sync
`core` before it builds. This PR adds a `sync` command so that
`angular-server` will use the latest core build during the normal build
action.
**2 - Resolving types errors in `angular-server`**
After properly syncing `core` in `angular-server` using the command
added, running build fails with the following:
<img width="400px" alt="Screenshot 2024-06-27 at 1 16 15 PM"
src="https://github.com/ionic-team/ionic-framework/assets/6577830/68d74750-821b-4776-b563-124d8fa06a79">
This was a regression in Stencil. `@stencil/core` has been updated to
resolve these errors so the build passes.
31 lines
904 B
YAML
31 lines
904 B
YAML
name: 'Build Ionic Angular Server'
|
|
description: 'Build Ionic Angular Server'
|
|
runs:
|
|
using: 'composite'
|
|
steps:
|
|
- uses: actions/setup-node@v4
|
|
with:
|
|
node-version: 18.x
|
|
- uses: ./.github/workflows/actions/download-archive
|
|
with:
|
|
name: ionic-core
|
|
path: ./core
|
|
filename: CoreBuild.zip
|
|
- name: Install Angular Server Dependencies
|
|
run: npm ci
|
|
shell: bash
|
|
working-directory: ./packages/angular-server
|
|
- name: Sync
|
|
run: npm run sync
|
|
shell: bash
|
|
working-directory: ./packages/angular-server
|
|
- name: Build
|
|
run: npm run build.prod
|
|
shell: bash
|
|
working-directory: ./packages/angular-server
|
|
- uses: ./.github/workflows/actions/upload-archive
|
|
with:
|
|
name: ionic-angular-server
|
|
output: packages/angular-server/AngularServerBuild.zip
|
|
paths: packages/angular-server/dist
|