mirror of
https://github.com/ionic-team/ionic-framework.git
synced 2026-03-13 10:22:08 +08:00
4826a3d9f5
Issue number: N/A --------- <!-- Please refer to our contributing documentation for any questions on submitting a pull request, or let us know here if you need any help: https://ionicframework.com/docs/building/contributing --> <!-- Some docs updates need to be made in the `ionic-docs` repo, in a separate PR. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#modifying-documentation for details. --> <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> This is the first PR to introduce the infrastructure required to add test generators to the Ionic Framework project. This PR introduces the file name changes necessary to support two playwright configs, so I recommend reviewing the PR by commit:1e5012cea1- Created a `playwright.config-legacy.ts` file and updates `package.json`. - Running `npm run test.e2e` will run the generator tests, and running `npm run test.e2e.legacy` will run the legacy tests.4fe8de7df7- Updates the GitHub Action scripts to run both the modern and legacy E2E tests. I added command modifiers to avoid collisions with output directories.e8bcfaf926- Updates `*.e2e.ts` files to have the legacy format name: `*.e2e-legacy.ts`. This naming scheme is required for the two Playwright configs to pull in the correct files. When migrating tests to generators, team members will rename the file to remove the `-legacy` part.5bf196c36d(warning: lots of files!) - Updates the `*.e2e.ts-snapshots` directories to have the legacy format name: `*.e2e-legacy.ts-snapshots`. The screenshot directory in Playwright is generated based on the test file name which is why we are updating the screenshot directory. When migrating tests to generators, team members will rename the directory to remove the `-legacy` part. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
252 lines
7.0 KiB
YAML
252 lines
7.0 KiB
YAML
name: 'Ionic Framework Build'
|
|
|
|
on:
|
|
pull_request:
|
|
branches: [ '**' ]
|
|
merge_group:
|
|
|
|
# When pushing a new commit we should
|
|
# cancel the previous test run to not
|
|
# consume more runners than we need to.
|
|
concurrency:
|
|
group: ${{ github.ref }}
|
|
cancel-in-progress: true
|
|
|
|
jobs:
|
|
build-core:
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
with:
|
|
# Checkout the latest commit in this branch
|
|
ref: ${{ github.event.pull_request.head.sha }}
|
|
- uses: ./.github/workflows/actions/build-core
|
|
|
|
test-core-clean-build:
|
|
needs: [build-core]
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- uses: ./.github/workflows/actions/test-core-clean-build
|
|
|
|
test-core-lint:
|
|
needs: [build-core]
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- uses: ./.github/workflows/actions/test-core-lint
|
|
|
|
test-core-spec:
|
|
needs: [build-core]
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- uses: ./.github/workflows/actions/test-core-spec
|
|
|
|
test-core-screenshot:
|
|
strategy:
|
|
matrix:
|
|
# Divide the tests into n buckets
|
|
# and run those buckets in parallel.
|
|
# To increase the number of shards,
|
|
# add new items to the shard array
|
|
# and change the value of totalShards
|
|
# to be the length of the shard array.
|
|
shard: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20]
|
|
totalShards: [20]
|
|
needs: [build-core]
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- uses: ./.github/workflows/actions/test-core-screenshot
|
|
with:
|
|
shard: ${{ matrix.shard }}
|
|
totalShards: ${{ matrix.totalShards }}
|
|
|
|
# Screenshots are required to pass
|
|
# in order for the branch to be merge
|
|
# eligible. However, the screenshot tests
|
|
# are run on n runners where n can change
|
|
# over time. The verify-screenshots step allows
|
|
# us to have a required status check for screenshot
|
|
# results without having to manually add each
|
|
# matrix run in the branch protection rules
|
|
# Source: https://github.community/t/status-check-for-a-matrix-jobs/127354
|
|
verify-screenshots:
|
|
if: ${{ always() }}
|
|
needs: test-core-screenshot
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- name: Check build matrix status
|
|
if: ${{ needs.test-core-screenshot.result != 'success' }}
|
|
run: exit 1
|
|
|
|
test-core-screenshot-legacy:
|
|
strategy:
|
|
matrix:
|
|
# Divide the tests into n buckets
|
|
# and run those buckets in parallel.
|
|
# To increase the number of shards,
|
|
# add new items to the shard array
|
|
# and change the value of totalShards
|
|
# to be the length of the shard array.
|
|
shard: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20]
|
|
totalShards: [20]
|
|
needs: [build-core]
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- uses: ./.github/workflows/actions/test-core-screenshot
|
|
with:
|
|
shard: ${{ matrix.shard }}
|
|
totalShards: ${{ matrix.totalShards }}
|
|
commandModifier: '.legacy'
|
|
|
|
# Screenshots are required to pass
|
|
# in order for the branch to be merge
|
|
# eligible. However, the screenshot tests
|
|
# are run on n runners where n can change
|
|
# over time. The verify-screenshots step allows
|
|
# us to have a required status check for screenshot
|
|
# results without having to manually add each
|
|
# matrix run in the branch protection rules
|
|
# Source: https://github.community/t/status-check-for-a-matrix-jobs/127354
|
|
verify-screenshots-legacy:
|
|
if: ${{ always() }}
|
|
needs: test-core-screenshot-legacy
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- name: Check build matrix status
|
|
if: ${{ needs.test-core-screenshot-legacy.result != 'success' }}
|
|
run: exit 1
|
|
|
|
build-vue:
|
|
needs: [build-core]
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- uses: ./.github/workflows/actions/build-vue
|
|
|
|
build-vue-router:
|
|
needs: [build-vue]
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- uses: ./.github/workflows/actions/build-vue-router
|
|
|
|
test-vue-e2e:
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
apps: [vue3]
|
|
needs: [build-vue, build-vue-router]
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- uses: ./.github/workflows/actions/test-vue-e2e
|
|
with:
|
|
app: ${{ matrix.apps }}
|
|
|
|
verify-test-vue-e2e:
|
|
if: ${{ always() }}
|
|
needs: test-vue-e2e
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- name: Check build matrix status
|
|
if: ${{ needs.test-vue-e2e.result != 'success' }}
|
|
run: exit 1
|
|
|
|
build-angular:
|
|
needs: [build-core]
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- uses: ./.github/workflows/actions/build-angular
|
|
|
|
build-angular-server:
|
|
needs: [build-angular]
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- uses: ./.github/workflows/actions/build-angular-server
|
|
|
|
test-angular-e2e:
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
apps: [ng14, ng15, ng16]
|
|
needs: [build-angular, build-angular-server]
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- uses: ./.github/workflows/actions/test-angular-e2e
|
|
with:
|
|
app: ${{ matrix.apps }}
|
|
|
|
verify-test-angular-e2e:
|
|
if: ${{ always() }}
|
|
needs: test-angular-e2e
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- name: Check build matrix status
|
|
if: ${{ needs.test-angular-e2e.result != 'success' }}
|
|
run: exit 1
|
|
|
|
build-react:
|
|
needs: [build-core]
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- uses: ./.github/workflows/actions/build-react
|
|
|
|
build-react-router:
|
|
needs: [build-react]
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- uses: ./.github/workflows/actions/build-react-router
|
|
|
|
test-react-router-e2e:
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
apps: [reactrouter5]
|
|
needs: [build-react, build-react-router]
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- uses: ./.github/workflows/actions/test-react-router-e2e
|
|
with:
|
|
app: ${{ matrix.apps }}
|
|
|
|
verify-test-react-router-e2e:
|
|
if: ${{ always() }}
|
|
needs: test-react-router-e2e
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- name: Check build matrix status
|
|
if: ${{ needs.test-react-router-e2e.result != 'success' }}
|
|
run: exit 1
|
|
|
|
test-react-e2e:
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
apps: [react17, react18]
|
|
needs: [build-react, build-react-router]
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- uses: ./.github/workflows/actions/test-react-e2e
|
|
with:
|
|
app: ${{ matrix.apps }}
|
|
|
|
verify-test-react-e2e:
|
|
if: ${{ always() }}
|
|
needs: test-react-e2e
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- name: Check build matrix status
|
|
if: ${{ needs.test-react-e2e.result != 'success' }}
|
|
run: exit 1
|