mirror of
https://github.com/ionic-team/ionic-framework.git
synced 2025-08-14 16:52:26 +08:00
1cf1eca002
closes #27949 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> - Typescript is complaining about the `onClick` event type of the `IonTabButton` ```ts const App: React.FC = () => { async function handleTabClick(e: CustomEvent<HTMLIonTabButtonElement>) { alert(e.detail.tab); } return ( <IonTabButton tab="myTab" onClick={handleTabClick}> ); }; ``` ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - `onClick` handler uses `CustomEvent` type - Typescript does not error ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->