ionic-framework

mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-10 00:27:41 +08:00

Files

Maria Hutt 33aa8e36d9 chore(alert): remove ion-buttons from tests (#28823 )

Issue number: internal

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

`ion-button` is being used as a way to open the alerts. It's not being
used to test functionality.

When `ion-button` is updated then the screenshots in the alert tests
must be updated. This shouldn't happen when `ion-button` isn't necessary
to have in these tests.


## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Replaced `ion-button` with `button`


## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!--
  If this introduces a breaking change:
1. Describe the impact and migration path for existing applications
below.
  2. Update the BREAKING.md file with the breaking change.
3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
See
https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer
for more information.
-->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

N/A

---------

Co-authored-by: ionitron <hi@ionicframework.com>

2024-01-15 22:05:46 +00:00

animations

refactor(many): use utils import (#27160 )

2023-04-12 13:25:14 -07:00

test

chore(alert): remove ion-buttons from tests (#28823 )

2024-01-15 22:05:46 +00:00

alert-interface.ts

feat(alert): add htmlAttributes property for passing attributes to buttons (#27862 )

2023-07-31 13:16:17 -04:00

alert.ios.scss

fix(alert): date inputs render correctly in mobile safari (#28495 )