mirror of https://github.com/ionic-team/ionic-framework.git synced 2026-03-13 10:22:08 +08:00

Files

Sean Perkins 2ce00cf292 fix(angular): remove invalid z-index style (#27559 )

Issue number: N/A

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

The Angular implementation of `ion-tabs` uses SASS styles in the inline
usage for styles:

```ts
styles: [`
  :host {
    z-index: $z-index-page-container;
  }
`]
```

However Angular is expecting CSS mark-up by default. This results in an
invalid value being assigned to the `z-index`.

![image
(10)](https://github.com/ionic-team/ionic-framework/assets/13732623/3a917c7e-bbb3-4ce2-afb9-d6d4f0d3824f)


## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Removes the invalid style from the tabs stylesheet
- Removes unnecessary leading whitespace from the template

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

2023-05-30 14:09:33 +00:00

scripts

chore(ci): enable npm package provenance (#27263 )

2023-04-24 13:04:10 +00:00

src

fix(angular): remove invalid z-index style (#27559 )

2023-05-30 14:09:33 +00:00

test

chore(angular): test app uses v16 dependencies (#27380 )

2023-05-04 19:17:08 +00:00

.eslintignore

feat(virtual-scroll): remove virtual scroll component (#25808 )

2022-08-24 15:42:12 -04:00

.eslintrc.json

feat(virtual-scroll): remove virtual scroll component (#25808 )

2022-08-24 15:42:12 -04:00

.prettierignore

chore(): sync with main

2022-09-30 12:27:17 -04:00

CHANGELOG.md

v7.0.9

2023-05-25 13:26:29 +00:00

ng-package.json

feat(angular,angular-server): angular v14 minimum support (#26822 )

2023-02-22 12:33:49 -05:00

package-lock.json

chore(): update package lock files

2023-05-25 13:26:42 +00:00

package.json

v7.0.9

2023-05-25 13:26:29 +00:00

README.md

docs(angular, core): change link from slack to discord (#27519 )

2023-05-19 20:23:36 +00:00

tsconfig.json

refactor(ci): do not cache node modules (#26265 )

2022-11-14 13:55:46 -05:00

tsconfig.schematics.json

feat(): support ng add (#15323 )

2018-11-27 13:36:59 -05:00

tslint.json

feat(angular): build for angular 12.0 (#23970 )

2021-10-15 16:54:59 -04:00

README.md

@ionic/angular

Ionic Angular specific building blocks on top of @ionic/core components.

License

Testing ng-add in ionic

Pull the latest from main
Build ionic/angular: npm run build
Run npm link from ionic/angular/dist directory
Create a blank angular project

ng new add-test
// Say yes to including the router, we need it
cd add-test

To run schematics locally, we need the schematics-cli (once published, this will not be needed)

npm install @angular-devkit/schematics-cli

Link @ionic/angular

npm link @ionic/angular

Run the local copy of the ng-add schematic

$ npx schematics @ionic/angular:ng-add

You'll now be able to add ionic components to a vanilla Angular app setup.

README.md

@ionic/angular

Related

License

Testing ng-add in ionic