javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-16 10:01:59 +08:00
Code Issues Packages Projects Releases Wiki Activity
Files
ionic-framework/packages/angular
History
Sean Perkins 77707b8c1e fix(angular): min/max validator for ion-input type number (#27993) 
Issue number: Resolves #23480

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

Angular's min/max validators do not work with `ion-input[type=number]`.
Using the built-in validators with `ion-input` will not update the
control status to invalid, reflect the `ng-invalid` class or report the
correct errors.

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- The `IonicModule` now includes two additional directive declarations
that extend Angular's built-in min/max validators and target the
`ion-input` component when using `type="number"`.

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->
2023-08-18 18:34:02 +00:00
..
scripts
refactor(angular): move to packages directory (#27719)
2023-07-05 17:52:35 +00:00
src
fix(angular): min/max validator for ion-input type number (#27993)
2023-08-18 18:34:02 +00:00
test
fix(angular): min/max validator for ion-input type number (#27993)
2023-08-18 18:34:02 +00:00
.eslintignore
refactor(angular): move to packages directory (#27719)
2023-07-05 17:52:35 +00:00
.eslintrc.json
refactor(angular): move to packages directory (#27719)
2023-07-05 17:52:35 +00:00
.prettierignore
refactor(angular): move to packages directory (#27719)
2023-07-05 17:52:35 +00:00
CHANGELOG.md
v7.3.0
2023-08-16 14:23:33 +00:00
ng-package.json
refactor(angular): move to packages directory (#27719)
2023-07-05 17:52:35 +00:00
package-lock.json
chore(): update package lock files
2023-08-16 14:23:51 +00:00
package.json
v7.3.0
2023-08-16 14:23:33 +00:00
README.md
refactor(angular): move to packages directory (#27719)
2023-07-05 17:52:35 +00:00
tsconfig.json
refactor(angular): move to packages directory (#27719)
2023-07-05 17:52:35 +00:00
tsconfig.schematics.json
refactor(angular): move to packages directory (#27719)
2023-07-05 17:52:35 +00:00
tslint.json
refactor(angular): move to packages directory (#27719)
2023-07-05 17:52:35 +00:00

README.md

@ionic/angular

Ionic Angular specific building blocks on top of @ionic/core components.

Related

License

Testing ng-add in ionic

  1. Pull the latest from main
  2. Build ionic/angular: npm run build
  3. Run npm link from ionic/angular/dist directory
  4. Create a blank angular project
ng new add-test
// Say yes to including the router, we need it
cd add-test
  1. To run schematics locally, we need the schematics-cli (once published, this will not be needed)
npm install @angular-devkit/schematics-cli
  1. Link @ionic/angular
npm link @ionic/angular
  1. Run the local copy of the ng-add schematic
$ npx schematics @ionic/angular:ng-add

You'll now be able to add ionic components to a vanilla Angular app setup.