mirror of
https://github.com/ionic-team/ionic-framework.git
synced 2025-08-15 09:34:19 +08:00
e8e5c4e1b6
Issue number: N/A
---------
<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->
<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->
## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->
If a dev wants to view a test page in dark mode, they have to manually
add the styles. This can lead to a slowdown. Plus they can't use
Playwright's `goto` to test both light and dark. In order to test dark
mode with Playwright, the dev would need to use `setContent` instead of
`goto`.
## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->
Dark mode can be added to any page by appending `palette=dark` to the
URL.
- The param will be used to add a link tag with the correct palette
file.
- Playwright will load the correct palette file when a dev uses `goto`
and `{ themes: ['dark'] }`
## Does this introduce a breaking change?
- [ ] Yes
- [x] No
<!--
If this introduces a breaking change:
1. Describe the impact and migration path for existing applications
below.
2. Update the BREAKING.md file with the breaking change.
3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
See
https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer
for more information.
-->
## Other information
<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->
I recommend using badge to try this out. It already has a `goto` in the
basic tests.
38 lines
1.1 KiB
JavaScript
38 lines
1.1 KiB
JavaScript
|
|
(function() {
|
|
|
|
if (window.location.search.indexOf('rtl=true') > -1) {
|
|
document.documentElement.setAttribute('dir', 'rtl');
|
|
}
|
|
|
|
if (window.location.search.indexOf('ionic:_testing=true') > -1) {
|
|
const style = document.createElement('style');
|
|
style.innerHTML = `
|
|
* {
|
|
caret-color: transparent !important;
|
|
}`;
|
|
document.head.appendChild(style);
|
|
}
|
|
|
|
/**
|
|
* The term `palette` is used to as a param to match the
|
|
* Ionic docs, plus here is already a `ionic:theme` query being
|
|
* used for `md`, `ios`, and `ionic` themes.
|
|
*/
|
|
const palette = window.location.search.match(/palette=([a-z]+)/);
|
|
if (palette && palette[1] !== 'light') {
|
|
const linkTag = document.createElement('link');
|
|
linkTag.setAttribute('rel', 'stylesheet');
|
|
linkTag.setAttribute('type', 'text/css');
|
|
linkTag.setAttribute('href', `/css/palettes/${palette[1]}.always.css`);
|
|
document.head.appendChild(linkTag);
|
|
}
|
|
|
|
window.Ionic = window.Ionic || {};
|
|
window.Ionic.config = window.Ionic.config || {};
|
|
|
|
window.addEventListener('appload', () => {
|
|
window.testAppLoaded = true;
|
|
})
|
|
})();
|