javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-15 09:34:19 +08:00
Code Issues Packages Projects Releases Wiki Activity
Files
ionic-framework/packages/angular
History
Shawn Taylor 1a135ebd76 refactor(angular): alert controller uses correct core instance (#28538) 
Issue number: Internal

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
As a takeaway from our learning session about a menuController bug in
Ionic Angular, the team would like to update our other providers to use
the same architecture as the menuController to prevent this kind of
issue from happening again in the future.

We also noticed that the common provider does not provide much value and
it's easier to just have two separate implementations in `src` and
`standalone`. (There wasn't much code we could de-duplicate)

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Removed the common alert provider in favor of separate ones in
src/standalone

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->
2023-11-16 16:50:43 +00:00
..
common
refactor(angular): alert controller uses correct core instance (#28538)
2023-11-16 16:50:43 +00:00
scripts
refactor(angular): move to packages directory (#27719)
2023-07-05 17:52:35 +00:00
src
refactor(angular): alert controller uses correct core instance (#28538)
2023-11-16 16:50:43 +00:00
standalone
refactor(angular): alert controller uses correct core instance (#28538)
2023-11-16 16:50:43 +00:00
test
refactor(angular): alert controller uses correct core instance (#28538)
2023-11-16 16:50:43 +00:00
.eslintignore
refactor(angular): move to packages directory (#27719)
2023-07-05 17:52:35 +00:00
.eslintrc.json
refactor(angular): move to packages directory (#27719)
2023-07-05 17:52:35 +00:00
.prettierignore
fix(angular): standalone form components do not error when multiple are used (#28423)
2023-10-27 19:08:54 +00:00
CHANGELOG.md
v7.5.5
2023-11-15 15:27:28 +00:00
ng-package.json
refactor(angular): move to packages directory (#27719)
2023-07-05 17:52:35 +00:00
package-lock.json
chore(): update package lock files
2023-11-15 15:27:39 +00:00
package.json
v7.5.5
2023-11-15 15:27:28 +00:00
README.md
feat(angular): ship Ionic components as Angular standalone components (#28311)
2023-10-10 13:06:23 -04:00
tsconfig.json
chore(angular): type checking for standalone directory (#28531)
2023-11-15 18:58:27 +00:00
tsconfig.schematics.json
refactor(angular): move to packages directory (#27719)
2023-07-05 17:52:35 +00:00

README.md

@ionic/angular

Ionic Angular specific building blocks on top of @ionic/core components.

Related

License

Testing ng-add in ionic

  1. Pull the latest from main
  2. Build ionic/angular: npm run build
  3. Run npm link from ionic/angular/dist directory
  4. Create a blank angular project
ng new add-test
// Say yes to including the router, we need it
cd add-test
  1. To run schematics locally, we need the schematics-cli (once published, this will not be needed)
npm install @angular-devkit/schematics-cli
  1. Link @ionic/angular
npm link @ionic/angular
  1. Run the local copy of the ng-add schematic
$ npx schematics @ionic/angular:ng-add

You'll now be able to add ionic components to a vanilla Angular app setup.

Project Structure

common

This is where logic that is shared between lazy loaded and standalone components live. For example, the lazy loaded IonPopover and standalone IonPopover components extend from a base IonPopover implementation that exists in this directory.

Note: This directory exposes internal APIs and is only accessed in the standalone and src submodules. Ionic developers should never import directly from @ionic/angular/common. Instead, they should import from @ionic/angular or @ionic/angular/standalone.

standalone

This is where the standalone component implementations live. It was added as a separate entry point to avoid any lazy loaded logic from accidentally being pulled in to the final build. Having a separate directory allows the lazy loaded implementation to remain accessible from @ionic/angular for backwards compatibility.

Ionic developers can access this by importing from @ionic/angular/standalone.

src

This is where the lazy loaded component implementations live.

Ionic developers can access this by importing from @ionic/angular.