mirror of
https://github.com/ionic-team/ionic-framework.git
synced 2026-03-13 10:22:08 +08:00
32bc33ed28
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> The `angular` directory sits at the root of the project instead of in `packages` with all the other JS Framework integrations. This does not cause any functional issues with Ionic, but it is confusing since integrations are not in a consistent place. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Moves the `angular` directory to `packages/angular` Note: Most files should remain unchanged. The only files I changed are the files that had direct paths to the old `angular` directory: 1. Removes the `angular` path in `lerna.json`. This is now covered by `packages/*` 2. Updated the angular file path in `.gitignore` 3. Updates the path to the angular package in `stencil.config.ts` for the Angular Output Targets 4. Updates some of Angular's sync scripts to correctly get the core stylesheets as well as the core package. 5. Updates the test app sync script to correctly sync core and angular-server ~I'm not entirely sure why GitHub thinks https://github.com/ionic-team/ionic-framework/pull/27719/files#diff-f5bba7e7c7c75426e2b9c89868310cb03890493b4efe0252adf8d12cc8398962 is a new file since it exists in `main` here:1f06be4a31/angular/test/base/scripts/build-ionic.sh~Fixed in6e7fc49827## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev build: `7.1.2-dev.11688052109.13454f5c`
124 lines
3.8 KiB
TypeScript
124 lines
3.8 KiB
TypeScript
describe('Modals', () => {
|
|
beforeEach(() => {
|
|
cy.visit('/modals');
|
|
})
|
|
|
|
it('should open standalone modal and close', () => {
|
|
cy.get('#action-button').click();
|
|
|
|
cy.get('ion-modal').should('exist').should('be.visible');
|
|
|
|
cy.get('app-modal-example h2').should('have.text', '123');
|
|
cy.get('app-modal-example h3').should('have.text', '321');
|
|
cy.get('#modalInstance').should('have.text', 'true');
|
|
|
|
cy.get('#onWillDismiss').should('have.text', 'false');
|
|
cy.get('#onDidDismiss').should('have.text', 'false');
|
|
|
|
cy.get('#close-modal').click();
|
|
|
|
cy.get('ion-modal').should('not.exist');
|
|
|
|
cy.get('#onWillDismiss').should('have.text', 'true');
|
|
cy.get('#onDidDismiss').should('have.text', 'true');
|
|
});
|
|
|
|
it('should open nav modal and close', () => {
|
|
cy.get('#action-button-2').click();
|
|
|
|
cy.get('ion-modal').should('exist').should('be.visible');
|
|
|
|
cy.get('ion-nav > *:last-child h2').should('have.text', '123');
|
|
cy.get('ion-nav > *:last-child h3').should('have.text', '321');
|
|
|
|
cy.get('ion-nav > *:last-child .push-page').click();
|
|
|
|
cy.get('ion-nav > *:last-child h2').should('have.text', 'pushed!');
|
|
cy.get('ion-nav > *:last-child h3').should('have.text', '');
|
|
|
|
cy.get('ion-nav > *:last-child .pop-page').click();
|
|
|
|
cy.get('ion-nav > *:last-child h2').should('have.text', '123');
|
|
});
|
|
|
|
});
|
|
|
|
describe('Modals: Inline', () => {
|
|
beforeEach(() => {
|
|
cy.visit('/modal-inline');
|
|
});
|
|
|
|
it('should initially have no items', () => {
|
|
cy.get('ion-list ion-item').should('not.exist');
|
|
});
|
|
|
|
it('should have items after opening', () => {
|
|
cy.get('#open-modal').click();
|
|
|
|
cy.get('ion-list ion-item:nth-child(1)').should('have.text', 'A');
|
|
cy.get('ion-list ion-item:nth-child(2)').should('have.text', 'B');
|
|
cy.get('ion-list ion-item:nth-child(3)').should('have.text', 'C');
|
|
cy.get('ion-list ion-item:nth-child(4)').should('have.text', 'D');
|
|
});
|
|
|
|
it('should have a div with .ion-page after opening', () => {
|
|
cy.get('#open-modal').click();
|
|
|
|
cy.get('ion-modal').children('.ion-page').should('exist');
|
|
});
|
|
|
|
it('should remove .ion-page when closing the modal', () => {
|
|
cy.get('#open-modal').click();
|
|
|
|
cy.get('ion-modal').children('.ion-page').should('exist');
|
|
cy.get('ion-modal').trigger('click', 20, 20);
|
|
|
|
cy.get('ion-modal').children('.ion-page').should('not.exist');
|
|
});
|
|
|
|
describe('setting the current breakpoint', () => {
|
|
|
|
it('should emit ionBreakpointDidChange', () => {
|
|
cy.get('#open-modal').click();
|
|
|
|
cy.get('ion-modal').then(modal => {
|
|
(modal.get(0) as any).setCurrentBreakpoint(1);
|
|
});
|
|
|
|
cy.get('#breakpointDidChange').should('have.text', '1');
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
describe('when in a modal', () => {
|
|
|
|
beforeEach(() => {
|
|
cy.visit('/modals');
|
|
cy.get('#action-button').click();
|
|
cy.get('#close-modal').click();
|
|
cy.get('#action-button').click();
|
|
});
|
|
|
|
it('should render ion-item item-has-value class when control value is set', () => {
|
|
cy.get('ion-select').click();
|
|
cy.get('ion-alert').should('exist').should('be.visible');
|
|
// Option 0 option
|
|
cy.get('ion-alert .alert-radio-button:nth-of-type(1)').click();
|
|
// Click confirm button
|
|
cy.get('ion-alert .alert-button:not(.alert-button-role-cancel)').click();
|
|
|
|
cy.get('#inputWithFloatingLabel').should('have.class', 'item-has-value');
|
|
});
|
|
|
|
it('should not render ion-item item-has-value class when control value is undefined', () => {
|
|
cy.get('#set-to-undefined').click();
|
|
cy.get('#inputWithFloatingLabel').should('not.have.class', 'item-has-value');
|
|
});
|
|
|
|
it('should not render ion-item item-has-value class when control value is null', () => {
|
|
cy.get('#set-to-null').click();
|
|
cy.get('#inputWithFloatingLabel').should('not.have.class', 'item-has-value');
|
|
});
|
|
}); |