mirror of
https://github.com/ionic-team/ionic-framework.git
synced 2025-11-10 00:27:41 +08:00
1113bd8f4a
Issue number: N/A --------- <!-- Please refer to our contributing documentation for any questions on submitting a pull request, or let us know here if you need any help: https://ionicframework.com/docs/building/contributing --> <!-- Some docs updates need to be made in the `ionic-docs` repo, in a separate PR. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#modifying-documentation for details. --> <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Popover tests are using legacy syntax ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Popover tests are using modern syntax8195bc6b09- The adjustment behavior test is only looking at y-axis values, which does not vary across mode/directions, so I removed those additional checks.cb5649c73b- The arrow behavior only exists on iOS, so I removed the MD checks.2956b8564f- The dismiss on select behavior does not vary across modes/directions, so I removed those additional checks.2cc055063a- The inline behavior does not vary across modes/directions, so I removed those additional checks.9ccc3a5e78- The sizing tests do not vary across modes/directions, so I removed those additional checks.9d95261e5d- The htmlAttributes test is now a spec test - I split the translucent tests into its own block and removed mode/direction tests+screenshots since this behavior only exists on iOS and does not vary across directions - All the other variants do not vary across directions, so I also split them into their own blocks and disabled RTL checks. ------- I ran into some difficulty integrating generators into some of the tests, so I decided to break some of the more complex tests up into multiple tests. The old utility functions were also calling `scrollIntoView` which can cause slowdowns on CI.4cc1cac45b- I created a popover test fixture and broke the basic tests into separate tests.e25c76977d- I Broke the reference screenshots into separate tests and had them use the fixture23a60c73cf- I updated the standalone test to use the fixture Note: The previous `scrollIntoView` usage seemed to cause Safari screenshots be sized 1px taller than if `scrollIntoView` was not used. As a result, there are some screenshot changes:7eb7d86413However, they should be limited to Safari and only contain the 1px height difference. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> --------- Co-authored-by: ionitron <hi@ionicframework.com>