mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-15 01:03:03 +08:00

Files

Amanda Johnston 0854a11a25 fix(angular,vue): range form value updates while dragging knob (#28422 )

Issue number: Resolves #28256

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

In the form integrations for Angular and Vue, the value of a range does
not update while the knob is actively being dragged, only when the knob
is released.

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

The form integrations now update the range's value when the `ionInput`
event fires, rather than `ionChange`.

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

I wasn't sure how to add reliable automated tests for this behavior. The
difference only applies when actively dragging the knob, and we've had
issues with such gestures being flaky in the past. I did add value
displays to the test apps so the behavior can be manually tested.

2023-10-30 10:18:53 -05:00

scripts

fix(react, vue): inline modals apply ion-page class (#27481 )

2023-05-24 13:37:02 +00:00

src

fix(angular,vue): range form value updates while dragging knob (#28422 )

2023-10-30 10:18:53 -05:00

test

fix(angular,vue): range form value updates while dragging knob (#28422 )

2023-10-30 10:18:53 -05:00

types

feat(slides): remove ion-slide, ion-slides, and IonicSwiper module (#25868 )

2022-09-01 14:36:17 -05:00

.eslintignore

chore(vue): add eslint and prettier (#26635 )

2023-01-18 18:29:25 -05:00

.eslintrc.js

chore(vue): add eslint and prettier (#26635 )

2023-01-18 18:29:25 -05:00

.prettierignore

chore(vue): add eslint and prettier (#26635 )

2023-01-18 18:29:25 -05:00

CHANGELOG.md

v7.5.1

2023-10-18 13:26:44 +00:00

package-lock.json

chore(): update package lock files

2023-10-18 13:27:01 +00:00

package.json

v7.5.1

2023-10-18 13:26:44 +00:00

README.md

docs(vue): update README instructions (#28175 )

2023-09-14 16:20:51 +00:00

rollup.config.js

refactor(vue): only ship es modules (#26054 )

2022-09-30 11:43:50 -04:00

tsconfig.json

feat(vue): add composition API ionic lifecycle hooks (#22970 )

2021-03-01 10:35:25 -05:00

README.md

@ionic/vue

Ionic Framework integration for Vue 3 apps.

Building

Install dependencies in @ionic/core:

cd core && npm install

Build @ionic/core. This will generate Vue component bindings in the packages/vue directory:

npm run build

Install dependencies in @ionic/vue:

cd packages/vue && npm install

Build @ionic/vue:

npm run build

Install dependencies in @ionic/vue-router:

cd packages/vue-router && npm install

Build @ionic/vue-router:

npm run build

Tests

E2E Tests are found in the packages/vue/test/base/tests directory and use Cypress.
When making changes to @ionic/vue or @ionic/vue-router you can run npm run sync in the test-app directory to ensure that the test application is using your built changes. Be sure to build in the vue and vue-router directories first.
Tests can be run in headless mode by running npm run cypress.
If you want to open the Cypress test runner, you can run node_modules/.bin/cypress open.
Bug fix and feature PRs should have new tests verifying the PR functionality.

Contributing

See our Contributing Guide.

Need Help?

Post your question on the Ionic Forum.