mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-17 18:54:11 +08:00

Files

Liam DeBeasi 02678f3652 fix(react, vue): inline modals apply ion-page class (#27481 )

Issue number: resolves #27470

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

Passing multiple elements in to an inline modal causes `.ion-page` to
not get set. This causes content to get pushed off the bottom of the
modal equal to the height of the header. React has some special CSS that
prevents this:
eb2772c0ce/packages/react/src/components/createInlineOverlayComponent.tsx (L137-L140)

However, I think this should be delegated to `.ion-page` instead so the
behavior is consistent across frameworks. For example, Angular uses
`.ion-page`:
eb2772c0ce/angular/src/directives/overlays/modal.ts (L82)

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Inline overlays in Ionic React and Ionic Vue wrap child content in
`.ion-delegate-host.ion-page`.
- Removed the custom flex styles from Ionic React as `.ion-page` has its
own styles.

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

Revised Design Doc:
https://github.com/ionic-team/ionic-framework-design-documents/pull/84

2023-05-24 13:37:02 +00:00

public

test(react): migrate to builder architecture (#26959 )

2023-03-17 16:21:21 -04:00

scripts

chore: sync script deletes existing tgz packages (#27045 )

2023-04-05 20:13:43 +00:00

src

fix(react, vue): inline modals apply ion-page class (#27481 )

2023-05-24 13:37:02 +00:00

tests/e2e

fix(react, vue): inline modals apply ion-page class (#27481 )

2023-05-24 13:37:02 +00:00

.gitignore

test(react): migrate to builder architecture (#26959 )

2023-03-17 16:21:21 -04:00

cypress.config.ts

test(react): migrate to builder architecture (#26959 )

2023-03-17 16:21:21 -04:00

ionic.config.json

test(react): migrate to builder architecture (#26959 )

2023-03-17 16:21:21 -04:00

README.md

test(react): migrate to builder architecture (#26959 )

2023-03-17 16:21:21 -04:00

tsconfig.json

test(react): migrate to builder architecture (#26959 )

2023-03-17 16:21:21 -04:00

README.md

React Test App

Getting Started

Setup

Make sure you are using the latest versions of node and npm. If you do not have these, download the installer for the LTS version of Node.js. This is the best way to also install npm.

Building Dependencies

Navigate to the core, packages/react and packages/react-router directories and build each of them:

npm i
npm run build

Then, install dependencies from this directory for this test app:

npm i

Syncing Changes

When making changes to the React package, run the following from this directory to sync the changes:

npm run sync

Previewing App

To preview this app locally, run the following from this directory:

npm start

Running Tests

To run the e2e tests, run the following from this directory:

npm run build
npm run e2e