javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-15 17:42:15 +08:00
Code Issues Packages Projects Releases Wiki Activity
Files
ionic-framework/angular/scripts
History
Sean Perkins ca9b9b65d2 chore: sync script deletes existing tgz packages (#27045) 
<!-- Please refer to our contributing documentation for any questions on
submitting a pull request, or let us know here if you need any help:
https://ionicframework.com/docs/building/contributing -->

## Pull request checklist

Please check if your PR fulfills the following requirements:
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been reviewed and added / updated if needed (for bug
fixes / features)
- Some docs updates need to be made in the `ionic-docs` repo, in a
separate PR. See the [contributing
guide](https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#modifying-documentation)
for details.
- [ ] Build (`npm run build`) was run locally and any changes were
pushed
- [ ] Lint (`npm run lint`) has passed locally and any fixes were made
for failures


## Pull request type

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type, submit multiple
pull requests if needed. -->

Please check the type of change your PR introduces:
- [ ] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, renaming)
- [ ] Refactoring (no functional changes, no api changes)
- [x] Build related changes
- [ ] Documentation content changes
- [ ] Other (please describe): 


## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

When testing changes locally, you can have an existing test app that you
sync the package contents to. If you have done this across different
versions of Ionic, it can install the wrong .tgz file instead of the
local changes.

Experienced here:
https://github.com/ionic-team/ionic-framework/pull/27040#pullrequestreview-1362136995

<!-- Issues are required for both bug fixes and features. -->
Issue URL: N/A


## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Sync script deletes all .tgz files local to the directory before
locally packing and installing the contents of the parent local packages

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

---------

Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
2023-04-05 20:13:43 +00:00
..
build-core.js
refactor(ci): do not cache node modules (#26265)
2022-11-14 13:55:46 -05:00
clean-generated.js
chore(): update angular build scripts
2018-03-26 16:31:40 -05:00
clean.js
feat(ssr): add ionic angular server (#18880)
2019-08-06 12:24:42 -05:00
link-copy.js
chore(angular): update angular tests to ng v6 and latest stencil
2018-05-16 11:40:28 -05:00
package.json
Update v3 package.json
2019-07-11 09:29:05 -05:00
README.md
Move package.json to angular directory for v3.
2019-07-10 12:47:40 -05:00
rollup.config.js
chore(deps): bump deps (#21632)
2020-06-29 10:21:06 -05:00
rollup.config.legacy.js
feat(ssr): add ionic angular server (#18880)
2019-08-06 12:24:42 -05:00
sync.sh
chore: sync script deletes existing tgz packages (#27045)
2023-04-05 20:13:43 +00:00

README.md

Local @ionic/angular test/testapp development

  1. npm install at the root of angular
  2. npm run build.dev to build local @ionic/angular and @ionic/core
  3. cd test/testapp to the test app
  4. npm install in the test app directory
  5. npm run serve copies packages and serve the app (see package.json for more options)
  6. http://localhost:4200/

npm link local development

npm link doesn't work as expected due to the devDependency on @angular/core. This is the work around...

npm run build.link ../ionic-conference-app

When the command above is ran from the angular directory, it will build @ionic/angular and copy the dist directory to the correct location of another local project. In the example above, the end result is that it copies the dist directory to ../ionic-conference-app/node_modules/@ionic/angular/dist. The path given should be relative to the root of this mono repo.

package.json note

The package.json file in this directory references Ionic 3 and is in here to get GitHub to properly show the Used By counts on the repo. Do not remove it!