mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-15 01:03:03 +08:00

Files

Liam DeBeasi 02678f3652 fix(react, vue): inline modals apply ion-page class (#27481 )

Issue number: resolves #27470

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

Passing multiple elements in to an inline modal causes `.ion-page` to
not get set. This causes content to get pushed off the bottom of the
modal equal to the height of the header. React has some special CSS that
prevents this:
eb2772c0ce/packages/react/src/components/createInlineOverlayComponent.tsx (L137-L140)

However, I think this should be delegated to `.ion-page` instead so the
behavior is consistent across frameworks. For example, Angular uses
`.ion-page`:
eb2772c0ce/angular/src/directives/overlays/modal.ts (L82)

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Inline overlays in Ionic React and Ionic Vue wrap child content in
`.ion-delegate-host.ion-page`.
- Removed the custom flex styles from Ionic React as `.ion-page` has its
own styles.

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

Revised Design Doc:
https://github.com/ionic-team/ionic-framework-design-documents/pull/84

2023-05-24 13:37:02 +00:00

scripts

fix(react, vue): inline modals apply ion-page class (#27481 )

2023-05-24 13:37:02 +00:00

src

fix(react, vue): inline modals apply ion-page class (#27481 )

2023-05-24 13:37:02 +00:00

test

fix(react, vue): inline modals apply ion-page class (#27481 )

2023-05-24 13:37:02 +00:00

types

feat(slides): remove ion-slide, ion-slides, and IonicSwiper module (#25868 )

2022-09-01 14:36:17 -05:00

.eslintignore

chore(vue): add eslint and prettier (#26635 )

2023-01-18 18:29:25 -05:00

.eslintrc.js

chore(vue): add eslint and prettier (#26635 )

2023-01-18 18:29:25 -05:00

.prettierignore

chore(vue): add eslint and prettier (#26635 )

2023-01-18 18:29:25 -05:00

CHANGELOG.md

v7.0.8

2023-05-24 12:39:07 +00:00

package-lock.json

chore(): update package lock files

2023-05-24 12:39:22 +00:00

package.json

v7.0.8

2023-05-24 12:39:07 +00:00

README.md

docs(): docs reference main instead of master (#24216 )

2021-11-12 14:31:18 -05:00

rollup.config.js

refactor(vue): only ship es modules (#26054 )

2022-09-30 11:43:50 -04:00

tsconfig.json

feat(vue): add composition API ionic lifecycle hooks (#22970 )

2021-03-01 10:35:25 -05:00

README.md

@ionic/vue

Ionic Framework integration for Vue 3 apps.

Building

Install dependencies in @ionic/core:

cd core && npm install

Build @ionic/core. This will generate Vue component bindings in the packages/vue directory:

npm run build

Install dependencies in @ionic/vue:

cd packages/vue && npm install

Build @ionic/vue:

npm run build

Tests

E2E Tests are found in the packages/vue/test-app/tests directory and use Cypress.
When making changes to @ionic/vue or @ionic/vue-router you can run npm run sync in the test-app directory to ensure that the test application is using your built changes. Be sure to build in the vue and vue-router directories first.
Tests can be run in headless mode by running npm run cypress.
If you want to open the Cypress test runner, you can run node_modules/.bin/cypress open.
Bug fix and feature PRs should have new tests verifying the PR functionality.

Contributing

See our Contributing Guide.

Need Help?

Post your question on the Ionic Forum.