mirror of
https://github.com/ionic-team/ionic-framework.git
synced 2025-08-15 01:03:03 +08:00

resolves #28201 This PR fixes the navigation issue related to `router.go` that was identified in issue #28201. After working on this issue I realised that @xxllxhdj has already created a PR for this in #29847. While their fix is great, I have added tests to replicate the issue, reused existing code and `undefined` will be returned in unexpected situations - which matches the existing functionality. ## What is the current behavior? If a user navigates from `/home` -> `/pageA` -> `/pageB` -> `/pageC` -> back to `/pageB` -> then `router.go(-2)` is called the URL will be updated to `/home` correctly, but the app will try to render `/pageA`. This happens for any delta < -1. ## What is the new behavior? The app will correctly render `/pageA`, which matches the URL. ## Does this introduce a breaking change? - [ ] Yes - [X] No --------- Co-authored-by: xxllxhdj <12881488+xxllxhdj@users.noreply.github.com>
109 lines
3.9 KiB
TypeScript
109 lines
3.9 KiB
TypeScript
import { createLocationHistory } from '../src/locationHistory';
|
|
|
|
let locationHistory;
|
|
describe('Location History', () => {
|
|
beforeEach(() => {
|
|
locationHistory = createLocationHistory();
|
|
});
|
|
|
|
it('should correctly add an item to location history', () => {
|
|
locationHistory.add({ pathname: '/' });
|
|
expect(locationHistory.canGoBack(1)).toEqual(false);
|
|
});
|
|
|
|
it('should correctly replace an item to location history', () => {
|
|
locationHistory.add({ pathname: '/home' });
|
|
locationHistory.add({ pathname: '/login', routerAction: 'replace' });
|
|
|
|
const current = locationHistory.last();
|
|
expect(current.pathname).toEqual('/login');
|
|
});
|
|
|
|
it('should correctly pop an item from location history', () => {
|
|
locationHistory.add({ pathname: '/home' });
|
|
locationHistory.add({ pathname: '/login', routerAction: 'pop' });
|
|
|
|
const current = locationHistory.last();
|
|
expect(current.pathname).toEqual('/login');
|
|
expect(locationHistory.canGoBack(1)).toEqual(false);
|
|
});
|
|
|
|
it('should correctly wipe location history when routerDirection is root', () => {
|
|
locationHistory.add({ pathname: '/home' });
|
|
locationHistory.add({ pathname: '/login' });
|
|
locationHistory.add({ pathname: '/logout', routerDirection: 'root' });
|
|
|
|
const current = locationHistory.last();
|
|
expect(current.pathname).toEqual('/logout');
|
|
expect(locationHistory.canGoBack(1)).toEqual(false);
|
|
});
|
|
|
|
it('should correctly update a route', () => {
|
|
locationHistory.add({ id: '1', pathname: '/tabs/tab1', tab: 'tab1' });
|
|
locationHistory.add({ id: '2', pathname: '/tabs/tab2' });
|
|
|
|
const current = { ...locationHistory.last() };
|
|
current.tab = 'tab2';
|
|
|
|
locationHistory.update(current);
|
|
|
|
const getCurrentAgain = locationHistory.last();
|
|
expect(getCurrentAgain.tab).toEqual('tab2');
|
|
});
|
|
|
|
it('should correctly get the first route for a tab', () => {
|
|
locationHistory.add({ id: '1', pathname: '/tabs/tab1', tab: 'tab1' });
|
|
locationHistory.add({ id: '2', pathname: '/tabs/tab1/child', tab: 'tab1' });
|
|
locationHistory.add({ id: '2', pathname: '/tabs/tab1/child/1', tab: 'tab1' });
|
|
|
|
const first = locationHistory.getFirstRouteInfoForTab('tab1');
|
|
expect(first.pathname).toEqual('/tabs/tab1');
|
|
});
|
|
|
|
it('should correctly get the current route for a tab', () => {
|
|
locationHistory.add({ id: '1', pathname: '/tabs/tab1', tab: 'tab1' });
|
|
locationHistory.add({ id: '2', pathname: '/tabs/tab1/child', tab: 'tab1' });
|
|
locationHistory.add({ id: '2', pathname: '/tabs/tab1/child/1', tab: 'tab1' });
|
|
|
|
const first = locationHistory.getCurrentRouteInfoForTab('tab1');
|
|
expect(first.pathname).toEqual('/tabs/tab1/child/1');
|
|
});
|
|
|
|
it('should correctly get last route', () => {
|
|
locationHistory.add({ pathname: '/home' });
|
|
locationHistory.add({ pathname: '/login' });
|
|
|
|
const current = locationHistory.last();
|
|
expect(current.pathname).toEqual('/login');
|
|
});
|
|
|
|
it('should correctly determine if we can go back', () => {
|
|
locationHistory.add({ pathname: '/home' });
|
|
locationHistory.add({ pathname: '/login' });
|
|
|
|
expect(locationHistory.canGoBack(1, 0, 1)).toEqual(true);
|
|
expect(locationHistory.canGoBack(2, 0, 1)).toEqual(false);
|
|
});
|
|
|
|
it('should correctly find the last location', () => {
|
|
const [home, pageA, pageB, pageC] = [
|
|
{ pathname: '/home' },
|
|
{ pathname: '/page-a', pushedByRoute: '/home' },
|
|
{ pathname: '/page-b', pushedByRoute: '/page-a' },
|
|
{ pathname: '/page-c', pushedByRoute: '/page-b' },
|
|
];
|
|
|
|
locationHistory.add(home);
|
|
locationHistory.add(pageA);
|
|
locationHistory.add(pageB);
|
|
locationHistory.add(pageC);
|
|
|
|
expect(locationHistory.findLastLocation(pageB)).toEqual(pageA);
|
|
expect(locationHistory.findLastLocation(pageB, -2)).toEqual(home);
|
|
|
|
expect(locationHistory.findLastLocation(pageC)).toEqual(pageB);
|
|
expect(locationHistory.findLastLocation(pageC, -2)).toEqual(pageA);
|
|
expect(locationHistory.findLastLocation(pageC, -3)).toEqual(home);
|
|
});
|
|
});
|