mirror of https://github.com/ionic-team/ionic-framework.git synced 2026-03-13 10:22:08 +08:00

Files

Liam DeBeasi 9050a9fbf5 fix(vue): respect keepContentsMounted if passed as attribute (#28167 )

Issue number: resolves #28165

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

The overlay implementation in Vue only checks for truthy
`keepContentsMounted` values. When setting this prop as an attribute,
the value of it is `''` which is falsy. As a result, content does not
get mounted.

One of Vue's ESLint rules states that this should be supported:
https://eslint.vuejs.org/rules/prefer-true-attribute-shorthand.html

Part of the issue may also be that Vue does not know the type of this
property and so it assume "any":

> The shorthand form is not always equivalent! If a prop accepts
multiple types, but Boolean is not the first one, a shorthand prop won't
pass true.

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- The overlay wrapper now checks for `''` values. If
`keepContentsMounted === ''` then the inner contents will be mounted
because this means the prop is being set using the attribute shorthand.

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

Dev build: `7.3.5-dev.11694621267.1e5f63c2`

2023-09-14 18:10:11 +00:00

scripts

fix(react, vue): inline modals apply ion-page class (#27481 )

2023-05-24 13:37:02 +00:00

src

fix(vue): respect keepContentsMounted if passed as attribute (#28167 )

2023-09-14 18:10:11 +00:00

test

fix(vue): respect keepContentsMounted if passed as attribute (#28167 )

2023-09-14 18:10:11 +00:00

types

feat(slides): remove ion-slide, ion-slides, and IonicSwiper module (#25868 )

2022-09-01 14:36:17 -05:00

.eslintignore

chore(vue): add eslint and prettier (#26635 )

2023-01-18 18:29:25 -05:00

.eslintrc.js

chore(vue): add eslint and prettier (#26635 )

2023-01-18 18:29:25 -05:00

.prettierignore

chore(vue): add eslint and prettier (#26635 )

2023-01-18 18:29:25 -05:00

CHANGELOG.md

v7.4.0

2023-09-14 13:06:52 +00:00

package-lock.json

chore(): update package lock files

2023-09-14 13:07:07 +00:00

package.json

v7.4.0

2023-09-14 13:06:52 +00:00

README.md

docs(vue): update README instructions (#28175 )

2023-09-14 16:20:51 +00:00

rollup.config.js

refactor(vue): only ship es modules (#26054 )

2022-09-30 11:43:50 -04:00

tsconfig.json

feat(vue): add composition API ionic lifecycle hooks (#22970 )

2021-03-01 10:35:25 -05:00

README.md

@ionic/vue

Ionic Framework integration for Vue 3 apps.

Building

Install dependencies in @ionic/core:

cd core && npm install

Build @ionic/core. This will generate Vue component bindings in the packages/vue directory:

npm run build

Install dependencies in @ionic/vue:

cd packages/vue && npm install

Build @ionic/vue:

npm run build

Install dependencies in @ionic/vue-router:

cd packages/vue-router && npm install

Build @ionic/vue-router:

npm run build

Tests

E2E Tests are found in the packages/vue/test/base/tests directory and use Cypress.
When making changes to @ionic/vue or @ionic/vue-router you can run npm run sync in the test-app directory to ensure that the test application is using your built changes. Be sure to build in the vue and vue-router directories first.
Tests can be run in headless mode by running npm run cypress.
If you want to open the Cypress test runner, you can run node_modules/.bin/cypress open.
Bug fix and feature PRs should have new tests verifying the PR functionality.

Contributing

See our Contributing Guide.

Need Help?

Post your question on the Ionic Forum.