mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-15 09:34:19 +08:00

Files

Shane a2e803a553 fix(tabs): add fallback to select tab if router integration fails (#30599 )

Issue number: resolves #30552

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

Something caused a timing shift in v8.6.0 that messed up the timing
required for react router to set the active tab ID. Currently, when the
router goes to set the tab ID, it's possibly too early and the tab may
not exist yet, causing it to go unset.

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

This PR is a workaround that allows tabs to check when they're rendered
if a tab should be selected as a fallback for the router not setting
them. I don't think the tabs, in the long run, should be responsible for
this, but I think this is a good intermediate step until the upcoming
react router upgrade, when we can look into a better solution for react
router that may require less timing precision.

This PR also adds regression tests for React to make sure this doesn't
happen again without getting noticed.

## Does this introduce a breaking change?

- [ ] Yes
- [X] No

<!--
  If this introduces a breaking change:
1. Describe the impact and migration path for existing applications
below.
  2. Update the BREAKING.md file with the breaking change.
3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
See
https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer
for more information.
-->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

**Current dev build:**
```
8.7.2-dev.11754338216.1a548096
```

2025-08-04 22:08:04 +00:00

apps

feat(deps): update ionicons to v8 (#30390 )

2025-07-30 16:45:20 -04:00

base

fix(tabs): add fallback to select tab if router integration fails (#30599 )

2025-08-04 22:08:04 +00:00

build.sh

feat(input-otp): add new input-otp component (#30386 )

2025-05-29 15:10:37 -04:00

README.md

chore(docs): consolidate the developer resource files into a docs/ directory (#29266 )

2024-04-08 19:06:26 +00:00

README.md

React E2E Test Apps

Refer to the React Testing documentation in order to build and run the test app.