mirror of
https://github.com/ionic-team/ionic-framework.git
synced 2025-12-19 05:19:42 +08:00
58d563805f
Issue number: resolves #30613 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Currently, when you load an accordion group, the initially selected accordion animates open. This is an unexpected change caused by upgrading Stencil to >= 4.21.0, which changed the way component lifecycles got triggered. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> With this change, we're waiting for the accordion in the accordion group to render and telling it if the update it's going through is the initial update or not. This allows it to decide to animate properly. ## Does this introduce a breaking change? - [ ] Yes - [X] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Current dev build: ``` 8.7.8-dev.11761840817.1bede576 ```
80 lines
3.3 KiB
TypeScript
80 lines
3.3 KiB
TypeScript
import { IonApp, IonRouterOutlet, setupIonicReact } from '@ionic/react';
|
|
import { IonReactRouter } from '@ionic/react-router';
|
|
import React from 'react';
|
|
import { Route } from 'react-router-dom';
|
|
|
|
/* Core CSS required for Ionic components to work properly */
|
|
import '@ionic/react/css/core.css';
|
|
|
|
/* Basic CSS for apps built with Ionic */
|
|
import '@ionic/react/css/normalize.css';
|
|
import '@ionic/react/css/structure.css';
|
|
import '@ionic/react/css/typography.css';
|
|
|
|
/* Optional CSS utils that can be commented out */
|
|
import '@ionic/react/css/padding.css';
|
|
import '@ionic/react/css/float-elements.css';
|
|
import '@ionic/react/css/text-alignment.css';
|
|
import '@ionic/react/css/text-transformation.css';
|
|
import '@ionic/react/css/flex-utils.css';
|
|
import '@ionic/react/css/display.css';
|
|
|
|
/* Theme variables */
|
|
import './theme/variables.css';
|
|
import Icons from './pages/Icons';
|
|
import Inputs from './pages/Inputs';
|
|
import Main from './pages/Main';
|
|
import Tabs from './pages/Tabs';
|
|
import TabsBasic from './pages/TabsBasic';
|
|
import NavComponent from './pages/navigation/NavComponent';
|
|
import TabsDirectNavigation from './pages/TabsDirectNavigation';
|
|
import IonModalConditional from './pages/overlay-components/IonModalConditional';
|
|
import IonModalConditionalSibling from './pages/overlay-components/IonModalConditionalSibling';
|
|
import IonModalDatetimeButton from './pages/overlay-components/IonModalDatetimeButton';
|
|
import IonModalMultipleChildren from './pages/overlay-components/IonModalMultipleChildren';
|
|
import IonPopoverNested from './pages/overlay-components/IonPopoverNested';
|
|
import KeepContentsMounted from './pages/overlay-components/KeepContentsMounted';
|
|
import OverlayComponents from './pages/overlay-components/OverlayComponents';
|
|
import OverlayHooks from './pages/overlay-hooks/OverlayHooks';
|
|
import ReorderGroup from './pages/ReorderGroup';
|
|
import AccordionGroup from './pages/AccordionGroup';
|
|
|
|
setupIonicReact();
|
|
|
|
const App: React.FC = () => (
|
|
<IonApp>
|
|
<IonReactRouter>
|
|
<IonRouterOutlet>
|
|
<Route exact path="/" component={Main} />
|
|
<Route path="/overlay-hooks" component={OverlayHooks} />
|
|
<Route path="/overlay-components" component={OverlayComponents} />
|
|
<Route path="/overlay-components/nested-popover" component={IonPopoverNested} />
|
|
<Route
|
|
path="/overlay-components/modal-conditional-sibling"
|
|
component={IonModalConditionalSibling}
|
|
/>
|
|
<Route path="/overlay-components/modal-conditional" component={IonModalConditional} />
|
|
<Route
|
|
path="/overlay-components/modal-datetime-button"
|
|
component={IonModalDatetimeButton}
|
|
/>
|
|
<Route
|
|
path="/overlay-components/modal-multiple-children"
|
|
component={IonModalMultipleChildren}
|
|
/>
|
|
<Route path="/keep-contents-mounted" component={KeepContentsMounted} />
|
|
<Route path="/navigation" component={NavComponent} />
|
|
<Route path="/tabs" component={Tabs} />
|
|
<Route path="/tabs-basic" component={TabsBasic} />
|
|
<Route path="/tabs-direct-navigation" component={TabsDirectNavigation} />
|
|
<Route path="/icons" component={Icons} />
|
|
<Route path="/inputs" component={Inputs} />
|
|
<Route path="/reorder-group" component={ReorderGroup} />
|
|
<Route path="/accordion-group" component={AccordionGroup} />
|
|
</IonRouterOutlet>
|
|
</IonReactRouter>
|
|
</IonApp>
|
|
);
|
|
|
|
export default App;
|