v6.4.4

fix(vue): unmount teleported components (#26647 )
Resolves #26644
2026-03-13 10:22:08 +08:00 · 2023-01-25 14:04:53 +00:00 · 2023-01-25 08:36:28 -05:00 · 2023-01-18 09:34:32 -05:00 · 2023-01-11 09:15:38 -05:00 · 2022-12-14 12:38:05 -05:00
30 changed files with 274 additions and 67 deletions
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -3,6 +3,30 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

+## [6.4.4](https://github.com/ionic-team/ionic-framework/compare/v6.4.3...v6.4.4) (2023-01-25)
+
+
+### Bug Fixes
+
+* **vue:** unmount teleported components ([#26647](https://github.com/ionic-team/ionic-framework/issues/26647)) ([e75f050](https://github.com/ionic-team/ionic-framework/commit/e75f050be5cd487874ad00f2536c109bf7c7233d)), closes [#26644](https://github.com/ionic-team/ionic-framework/issues/26644)
+
+
+
+## [6.0.16](https://github.com/ionic-team/ionic-framework/compare/v6.0.15...v6.0.16) (2022-04-08)
+
+
+### Bug Fixes
+
+* **angular:** button components now route correctly without reload ([#25071](https://github.com/ionic-team/ionic-framework/issues/25071)) ([fb994fa](https://github.com/ionic-team/ionic-framework/commit/fb994fa9a7721a3575fb8d123be34aea4bf076a4))
+
+
+
+## [6.0.15](https://github.com/ionic-team/ionic-framework/compare/v6.0.14...v6.0.15) (2022-04-06)
+
+
+
+
+
 ## [6.4.3](https://github.com/ionic-team/ionic-framework/compare/v6.4.2...v6.4.3) (2023-01-18)


--- a/angular/CHANGELOG.md
+++ b/angular/CHANGELOG.md
@@ -3,6 +3,25 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

+## [6.4.4](https://github.com/ionic-team/ionic/compare/v6.4.3...v6.4.4) (2023-01-25)
+
+
+
+## [6.0.16](https://github.com/ionic-team/ionic/compare/v6.0.15...v6.0.16) (2022-04-08)
+
+
+### Bug Fixes
+
+* **angular:** button components now route correctly without reload ([#25071](https://github.com/ionic-team/ionic/issues/25071)) ([fb994fa](https://github.com/ionic-team/ionic/commit/fb994fa9a7721a3575fb8d123be34aea4bf076a4))
+
+
+
+## [6.0.15](https://github.com/ionic-team/ionic/compare/v6.0.14...v6.0.15) (2022-04-06)
+
+
+
+
+
 ## [6.4.3](https://github.com/ionic-team/ionic/compare/v6.4.2...v6.4.3) (2023-01-18)

 **Note:** Version bump only for package @ionic/angular
@@ -371,7 +390,7 @@ See [Conventional Commits](https://conventionalcommits.org) for commit guideline



-# [6.1.0](https://github.com/ionic-team/ionic/compare/v6.0.14...v6.1.0) (2022-04-13)
+# [6.1.0](https://github.com/ionic-team/ionic/compare/v6.0.16...v6.1.0) (2022-04-13)


 ### Bug Fixes
--- a/angular/package-lock.json
+++ b/angular/package-lock.json
@@ -1,15 +1,15 @@
 {
  "name": "@ionic/angular",
-  "version": "6.4.3",
+  "version": "6.4.4",
  "lockfileVersion": 2,
  "requires": true,
  "packages": {
    "": {
      "name": "@ionic/angular",
-      "version": "6.4.3",
+      "version": "6.4.4",
      "license": "MIT",
      "dependencies": {
-        "@ionic/core": "^6.4.3",
+        "@ionic/core": "^6.4.4",
        "ionicons": "^6.0.4",
        "jsonc-parser": "^3.0.0",
        "tslib": "^2.0.0"
--- a/angular/package.json
+++ b/angular/package.json
@@ -1,6 +1,6 @@
 {
  "name": "@ionic/angular",
-  "version": "6.4.3",
+  "version": "6.4.4",
  "description": "Angular specific wrappers for @ionic/core",
  "keywords": [
    "ionic",
@@ -42,7 +42,7 @@
    "validate": "npm i && npm run lint && npm run test && npm run build"
  },
  "dependencies": {
-    "@ionic/core": "^6.4.3",
+    "@ionic/core": "^6.4.4",
    "ionicons": "^6.0.4",
    "jsonc-parser": "^3.0.0",
    "tslib": "^2.0.0"
--- a/core/CHANGELOG.md
+++ b/core/CHANGELOG.md
@@ -3,6 +3,22 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

+## [6.4.4](https://github.com/ionic-team/ionic/compare/v6.4.3...v6.4.4) (2023-01-25)
+
+
+
+## [6.0.16](https://github.com/ionic-team/ionic/compare/v6.0.15...v6.0.16) (2022-04-08)
+
+
+
+## [6.0.15](https://github.com/ionic-team/ionic/compare/v6.0.14...v6.0.15) (2022-04-06)
+
+**Note:** Version bump only for package @ionic/core
+
+
+
+
+
 ## [6.4.3](https://github.com/ionic-team/ionic/compare/v6.4.2...v6.4.3) (2023-01-18)


@@ -602,7 +618,7 @@ See [Conventional Commits](https://conventionalcommits.org) for commit guideline



-# [6.1.0](https://github.com/ionic-team/ionic/compare/v6.0.14...v6.1.0) (2022-04-13)
+# [6.1.0](https://github.com/ionic-team/ionic/compare/v6.0.16...v6.1.0) (2022-04-13)


 ### Bug Fixes
--- a/core/package-lock.json
+++ b/core/package-lock.json
@@ -1,12 +1,12 @@
 {
  "name": "@ionic/core",
-  "version": "6.4.3",
+  "version": "6.4.4",
  "lockfileVersion": 2,
  "requires": true,
  "packages": {
    "": {
      "name": "@ionic/core",
-      "version": "6.4.3",
+      "version": "6.4.4",
      "license": "MIT",
      "dependencies": {
        "@stencil/core": "^2.18.0",
--- a/core/package.json
+++ b/core/package.json
@@ -1,6 +1,6 @@
 {
  "name": "@ionic/core",
-  "version": "6.4.3",
+  "version": "6.4.4",
  "description": "Base components for Ionic",
  "keywords": [
    "ionic",
--- a/docs/CHANGELOG.md
+++ b/docs/CHANGELOG.md
@@ -3,6 +3,22 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

+## [6.4.4](https://github.com/ionic-team/ionic-docs/compare/v6.4.3...v6.4.4) (2023-01-25)
+
+
+
+## [6.0.16](https://github.com/ionic-team/ionic-docs/compare/v6.0.15...v6.0.16) (2022-04-08)
+
+
+
+## [6.0.15](https://github.com/ionic-team/ionic-docs/compare/v6.0.14...v6.0.15) (2022-04-06)
+
+**Note:** Version bump only for package @ionic/docs
+
+
+
+
+
 ## [6.4.3](https://github.com/ionic-team/ionic-docs/compare/v6.4.2...v6.4.3) (2023-01-18)

 **Note:** Version bump only for package @ionic/docs
@@ -323,7 +339,7 @@ See [Conventional Commits](https://conventionalcommits.org) for commit guideline



-# [6.1.0](https://github.com/ionic-team/ionic-docs/compare/v6.0.14...v6.1.0) (2022-04-13)
+# [6.1.0](https://github.com/ionic-team/ionic-docs/compare/v6.0.16...v6.1.0) (2022-04-13)

 **Note:** Version bump only for package @ionic/docs

--- a/docs/package-lock.json
+++ b/docs/package-lock.json
@@ -1,12 +1,12 @@
 {
  "name": "@ionic/docs",
-  "version": "6.4.3",
+  "version": "6.4.4",
  "lockfileVersion": 2,
  "requires": true,
  "packages": {
    "": {
      "name": "@ionic/docs",
-      "version": "6.4.3",
+      "version": "6.4.4",
      "license": "MIT"
    }
  }
--- a/docs/package.json
+++ b/docs/package.json
@@ -1,6 +1,6 @@
 {
  "name": "@ionic/docs",
-  "version": "6.4.3",
+  "version": "6.4.4",
  "description": "Pre-packaged API documentation for the Ionic docs.",
  "main": "core.json",
  "types": "core.d.ts",
--- a/lerna.json
+++ b/lerna.json
@@ -5,5 +5,5 @@
    "angular",
    "packages/*"
  ],
-  "version": "6.4.3"
+  "version": "6.4.4"
 }
--- a/packages/angular-server/CHANGELOG.md
+++ b/packages/angular-server/CHANGELOG.md
@@ -3,6 +3,22 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

+## [6.4.4](https://github.com/ionic-team/ionic/compare/v6.4.3...v6.4.4) (2023-01-25)
+
+
+
+## [6.0.16](https://github.com/ionic-team/ionic/compare/v6.0.15...v6.0.16) (2022-04-08)
+
+
+
+## [6.0.15](https://github.com/ionic-team/ionic/compare/v6.0.14...v6.0.15) (2022-04-06)
+
+**Note:** Version bump only for package @ionic/angular-server
+
+
+
+
+
 ## [6.4.3](https://github.com/ionic-team/ionic/compare/v6.4.2...v6.4.3) (2023-01-18)

 **Note:** Version bump only for package @ionic/angular-server
@@ -323,7 +339,7 @@ See [Conventional Commits](https://conventionalcommits.org) for commit guideline



-# [6.1.0](https://github.com/ionic-team/ionic/compare/v6.0.14...v6.1.0) (2022-04-13)
+# [6.1.0](https://github.com/ionic-team/ionic/compare/v6.0.16...v6.1.0) (2022-04-13)

 **Note:** Version bump only for package @ionic/angular-server

--- a/packages/angular-server/package-lock.json
+++ b/packages/angular-server/package-lock.json
@@ -1,12 +1,12 @@
 {
  "name": "@ionic/angular-server",
-  "version": "6.4.3",
+  "version": "6.4.4",
  "lockfileVersion": 2,
  "requires": true,
  "packages": {
    "": {
      "name": "@ionic/angular-server",
-      "version": "6.4.3",
+      "version": "6.4.4",
      "license": "MIT",
      "devDependencies": {
        "@angular-eslint/eslint-plugin": "^12.6.1",
@@ -18,7 +18,7 @@
        "@angular/platform-browser": "^12.0.0",
        "@angular/platform-browser-dynamic": "^12.2.10",
        "@angular/platform-server": "^12.0.0",
-        "@ionic/core": "^6.4.3",
+        "@ionic/core": "^6.4.4",
        "@ionic/eslint-config": "^0.3.0",
        "@ionic/prettier-config": "^2.0.0",
        "@typescript-eslint/eslint-plugin": "^5.2.0",
--- a/packages/angular-server/package.json
+++ b/packages/angular-server/package.json
@@ -1,6 +1,6 @@
 {
  "name": "@ionic/angular-server",
-  "version": "6.4.3",
+  "version": "6.4.4",
  "description": "Angular SSR Module for Ionic",
  "keywords": [
    "ionic",
@@ -55,7 +55,7 @@
    "@angular/platform-browser": "^12.0.0",
    "@angular/platform-browser-dynamic": "^12.2.10",
    "@angular/platform-server": "^12.0.0",
-    "@ionic/core": "^6.4.3",
+    "@ionic/core": "^6.4.4",
    "@ionic/eslint-config": "^0.3.0",
    "@ionic/prettier-config": "^2.0.0",
    "@typescript-eslint/eslint-plugin": "^5.2.0",
--- a/packages/react-router/CHANGELOG.md
+++ b/packages/react-router/CHANGELOG.md
@@ -3,6 +3,22 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

+## [6.4.4](https://github.com/ionic-team/ionic/compare/v6.4.3...v6.4.4) (2023-01-25)
+
+
+
+## [6.0.16](https://github.com/ionic-team/ionic/compare/v6.0.15...v6.0.16) (2022-04-08)
+
+
+
+## [6.0.15](https://github.com/ionic-team/ionic/compare/v6.0.14...v6.0.15) (2022-04-06)
+
+**Note:** Version bump only for package @ionic/react-router
+
+
+
+
+
 ## [6.4.3](https://github.com/ionic-team/ionic/compare/v6.4.2...v6.4.3) (2023-01-18)

 **Note:** Version bump only for package @ionic/react-router
@@ -335,7 +351,7 @@ See [Conventional Commits](https://conventionalcommits.org) for commit guideline



-# [6.1.0](https://github.com/ionic-team/ionic/compare/v6.0.14...v6.1.0) (2022-04-13)
+# [6.1.0](https://github.com/ionic-team/ionic/compare/v6.0.16...v6.1.0) (2022-04-13)

 **Note:** Version bump only for package @ionic/react-router

--- a/packages/react-router/package-lock.json
+++ b/packages/react-router/package-lock.json
@@ -1,15 +1,15 @@
 {
  "name": "@ionic/react-router",
-  "version": "6.4.3",
+  "version": "6.4.4",
  "lockfileVersion": 2,
  "requires": true,
  "packages": {
    "": {
      "name": "@ionic/react-router",
-      "version": "6.4.3",
+      "version": "6.4.4",
      "license": "MIT",
      "dependencies": {
-        "@ionic/react": "^6.4.3",
+        "@ionic/react": "^6.4.4",
        "tslib": "*"
      },
      "devDependencies": {
--- a/packages/react-router/package.json
+++ b/packages/react-router/package.json
@@ -1,6 +1,6 @@
 {
  "name": "@ionic/react-router",
-  "version": "6.4.3",
+  "version": "6.4.4",
  "description": "React Router wrapper for @ionic/react",
  "keywords": [
    "ionic",
@@ -36,7 +36,7 @@
    "dist/"
  ],
  "dependencies": {
-    "@ionic/react": "^6.4.3",
+    "@ionic/react": "^6.4.4",
    "tslib": "*"
  },
  "peerDependencies": {
--- a/packages/react/CHANGELOG.md
+++ b/packages/react/CHANGELOG.md
@@ -3,6 +3,22 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

+## [6.4.4](https://github.com/ionic-team/ionic/compare/v6.4.3...v6.4.4) (2023-01-25)
+
+
+
+## [6.0.16](https://github.com/ionic-team/ionic/compare/v6.0.15...v6.0.16) (2022-04-08)
+
+
+
+## [6.0.15](https://github.com/ionic-team/ionic/compare/v6.0.14...v6.0.15) (2022-04-06)
+
+**Note:** Version bump only for package @ionic/react
+
+
+
+
+
 ## [6.4.3](https://github.com/ionic-team/ionic/compare/v6.4.2...v6.4.3) (2023-01-18)

 **Note:** Version bump only for package @ionic/react
@@ -377,7 +393,7 @@ See [Conventional Commits](https://conventionalcommits.org) for commit guideline



-# [6.1.0](https://github.com/ionic-team/ionic/compare/v6.0.14...v6.1.0) (2022-04-13)
+# [6.1.0](https://github.com/ionic-team/ionic/compare/v6.0.16...v6.1.0) (2022-04-13)

 **Note:** Version bump only for package @ionic/react

--- a/packages/react/package-lock.json
+++ b/packages/react/package-lock.json
@@ -1,15 +1,15 @@
 {
  "name": "@ionic/react",
-  "version": "6.4.3",
+  "version": "6.4.4",
  "lockfileVersion": 2,
  "requires": true,
  "packages": {
    "": {
      "name": "@ionic/react",
-      "version": "6.4.3",
+      "version": "6.4.4",
      "license": "MIT",
      "dependencies": {
-        "@ionic/core": "^6.4.3",
+        "@ionic/core": "^6.4.4",
        "ionicons": "^6.0.2",
        "tslib": "*"
      },
--- a/packages/react/package.json
+++ b/packages/react/package.json
@@ -1,6 +1,6 @@
 {
  "name": "@ionic/react",
-  "version": "6.4.3",
+  "version": "6.4.4",
  "description": "React specific wrapper for @ionic/core",
  "keywords": [
    "ionic",
@@ -40,7 +40,7 @@
    "css/"
  ],
  "dependencies": {
-    "@ionic/core": "^6.4.3",
+    "@ionic/core": "^6.4.4",
    "ionicons": "^6.0.2",
    "tslib": "*"
  },
--- a/packages/vue-router/CHANGELOG.md
+++ b/packages/vue-router/CHANGELOG.md
@@ -3,6 +3,22 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

+## [6.4.4](https://github.com/ionic-team/ionic/compare/v6.4.3...v6.4.4) (2023-01-25)
+
+
+
+## [6.0.16](https://github.com/ionic-team/ionic/compare/v6.0.15...v6.0.16) (2022-04-08)
+
+
+
+## [6.0.15](https://github.com/ionic-team/ionic/compare/v6.0.14...v6.0.15) (2022-04-06)
+
+**Note:** Version bump only for package @ionic/vue-router
+
+
+
+
+
 ## [6.4.3](https://github.com/ionic-team/ionic/compare/v6.4.2...v6.4.3) (2023-01-18)

 **Note:** Version bump only for package @ionic/vue-router
@@ -338,7 +354,7 @@ See [Conventional Commits](https://conventionalcommits.org) for commit guideline



-# [6.1.0](https://github.com/ionic-team/ionic/compare/v6.0.14...v6.1.0) (2022-04-13)
+# [6.1.0](https://github.com/ionic-team/ionic/compare/v6.0.16...v6.1.0) (2022-04-13)


 ### Bug Fixes
--- a/packages/vue-router/package-lock.json
+++ b/packages/vue-router/package-lock.json
@@ -1,15 +1,15 @@
 {
  "name": "@ionic/vue-router",
-  "version": "6.4.3",
+  "version": "6.4.4",
  "lockfileVersion": 2,
  "requires": true,
  "packages": {
    "": {
      "name": "@ionic/vue-router",
-      "version": "6.4.3",
+      "version": "6.4.4",
      "license": "MIT",
      "dependencies": {
-        "@ionic/vue": "^6.4.3"
+        "@ionic/vue": "^6.4.4"
      },
      "devDependencies": {
        "@types/jest": "^28.1.1",
--- a/packages/vue-router/package.json
+++ b/packages/vue-router/package.json
@@ -1,6 +1,6 @@
 {
  "name": "@ionic/vue-router",
-  "version": "6.4.3",
+  "version": "6.4.4",
  "description": "Vue Router integration for @ionic/vue",
  "scripts": {
    "test.spec": "jest",
@@ -43,7 +43,7 @@
  },
  "homepage": "https://github.com/ionic-team/ionic#readme",
  "dependencies": {
-    "@ionic/vue": "^6.4.3"
+    "@ionic/vue": "^6.4.4"
  },
  "devDependencies": {
    "@types/jest": "^28.1.1",
--- a/packages/vue/CHANGELOG.md
+++ b/packages/vue/CHANGELOG.md
@@ -3,6 +3,25 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

+## [6.4.4](https://github.com/ionic-team/ionic/compare/v6.4.3...v6.4.4) (2023-01-25)
+
+
+### Bug Fixes
+
+* **vue:** unmount teleported components ([#26647](https://github.com/ionic-team/ionic/issues/26647)) ([e75f050](https://github.com/ionic-team/ionic/commit/e75f050be5cd487874ad00f2536c109bf7c7233d)), closes [#26644](https://github.com/ionic-team/ionic/issues/26644)
+
+
+
+## [6.0.16](https://github.com/ionic-team/ionic/compare/v6.0.15...v6.0.16) (2022-04-08)
+
+
+
+## [6.0.15](https://github.com/ionic-team/ionic/compare/v6.0.14...v6.0.15) (2022-04-06)
+
+
+
+
+
 ## [6.4.3](https://github.com/ionic-team/ionic/compare/v6.4.2...v6.4.3) (2023-01-18)

 **Note:** Version bump only for package @ionic/vue
@@ -384,7 +403,7 @@ See [Conventional Commits](https://conventionalcommits.org) for commit guideline



-# [6.1.0](https://github.com/ionic-team/ionic/compare/v6.0.14...v6.1.0) (2022-04-13)
+# [6.1.0](https://github.com/ionic-team/ionic/compare/v6.0.16...v6.1.0) (2022-04-13)


 ### Bug Fixes
--- a/packages/vue/package-lock.json
+++ b/packages/vue/package-lock.json
@@ -1,15 +1,15 @@
 {
  "name": "@ionic/vue",
-  "version": "6.4.3",
+  "version": "6.4.4",
  "lockfileVersion": 2,
  "requires": true,
  "packages": {
    "": {
      "name": "@ionic/vue",
-      "version": "6.4.3",
+      "version": "6.4.4",
      "license": "MIT",
      "dependencies": {
-        "@ionic/core": "^6.4.3",
+        "@ionic/core": "^6.4.4",
        "ionicons": "^6.0.2"
      },
      "devDependencies": {
--- a/packages/vue/package.json
+++ b/packages/vue/package.json
@@ -1,6 +1,6 @@
 {
  "name": "@ionic/vue",
-  "version": "6.4.3",
+  "version": "6.4.4",
  "description": "Vue specific wrapper for @ionic/core",
  "scripts": {
    "lint": "echo add linter",
@@ -60,7 +60,7 @@
    "vue-router": "^4.0.16"
  },
  "dependencies": {
-    "@ionic/core": "^6.4.3",
+    "@ionic/core": "^6.4.4",
    "ionicons": "^6.0.2"
  },
  "vetur": {
--- a/packages/vue/src/components/IonApp.ts
+++ b/packages/vue/src/components/IonApp.ts
@@ -33,14 +33,7 @@ export const addTeleportedUserComponent = (component: VNode) => {
 }

 export const removeTeleportedUserComponent = (component: VNode) => {
-  /**
-   * Finds the index of the component in the array and removes it.
-   * Previously we were using a filter to remove the component from the array,
-   * but this was causing a bug where dismissing an overlay and then presenting
-   * a new overlay, would cause the new overlay to be removed.
-   */
-  const index = userComponents.value.findIndex(cmp => cmp === component);
-  if (index !== -1) {
-    userComponents.value.splice(index, 1);
-  }
-}
+  userComponents.value = userComponents.value.filter(
+    (cmp) => cmp !== component
+  );
+};
--- a/packages/vue/src/framework-delegate.ts
+++ b/packages/vue/src/framework-delegate.ts
@@ -3,9 +3,20 @@ import type { FrameworkDelegate } from '@ionic/core/components';

 import { addTeleportedUserComponent, removeTeleportedUserComponent } from './components/IonApp';

-export const VueDelegate = (addFn = addTeleportedUserComponent, removeFn = removeTeleportedUserComponent): FrameworkDelegate => {
-  let Component: VNode | undefined;
-  const attachViewToDom = (parentElement: HTMLElement, component: any, componentProps: any = {}, classes?: string[]) => {
+export const VueDelegate = (
+  addFn = addTeleportedUserComponent,
+  removeFn = removeTeleportedUserComponent
+): FrameworkDelegate => {
+  // `h` doesn't provide a type for the component argument
+  const refMap = new WeakMap<any, VNode>();
+
+  // TODO(FW-2969): types
+  const attachViewToDom = (
+    parentElement: HTMLElement,
+    component: any,
+    componentProps: any = {},
+    classes?: string[]
+  ) => {
    /**
     * Ionic Framework passes in modal and popover element
     * refs as props, but if these are not defined
@@ -19,19 +30,23 @@ export const VueDelegate = (addFn = addTeleportedUserComponent, removeFn = remov
    classes && div.classList.add(...classes);
    parentElement.appendChild(div);

-    Component = h(
+    const hostComponent = h(
      Teleport,
      { to: div },
      h(component, { ...componentProps })
    );

-    addFn(Component);
+    refMap.set(component, hostComponent);
+
+    addFn(hostComponent);

    return Promise.resolve(div);
  }

-  const removeViewFromDom = () => {
-    Component && removeFn(Component);
+  const removeViewFromDom = (_container: any, component: any) => {
+    const hostComponent = refMap.get(component);
+    hostComponent && removeFn(hostComponent);
+
    return Promise.resolve();
  }

--- a/packages/vue/test/base/src/components/ModalContent.vue
+++ b/packages/vue/test/base/src/components/ModalContent.vue
@@ -9,7 +9,8 @@
      </ion-toolbar>
    </ion-header>
    <ion-content class="ion-padding">
-      {{ title }}
+      <ion-label id="title">{{ title }}</ion-label>
+      <ion-input></ion-input>
    </ion-content>
  </ion-page>
 </template>
@@ -23,6 +24,7 @@ import {
  IonHeader,
  IonTitle,
  IonToolbar,
+  IonInput,
  modalController
 } from '@ionic/vue';
 import { defineComponent } from 'vue';
@@ -38,7 +40,8 @@ export default defineComponent({
    IonContent,
    IonHeader,
    IonTitle,
-    IonToolbar
+    IonToolbar,
+    IonInput
  },
  setup() {
    const dismiss = async () => {
--- a/packages/vue/test/base/tests/e2e/specs/overlays.cy.js
+++ b/packages/vue/test/base/tests/e2e/specs/overlays.cy.js
@@ -114,7 +114,7 @@ describe('Overlays', () => {
    cy.get('ion-button#present-overlay').click();
    cy.get('ion-modal').should('exist');

-    cy.get('ion-modal ion-content').should('have.text', 'Custom Title');
+    cy.get('ion-modal ion-content #title').should('have.text', 'Custom Title');
  });

  it('should pass props to modal via component', () => {
@@ -124,7 +124,7 @@ describe('Overlays', () => {
    cy.get('ion-button#present-overlay').click();
    cy.get('ion-modal').should('exist');

-    cy.get('ion-modal ion-content').should('have.text', 'Custom Title');
+    cy.get('ion-modal ion-content #title').should('have.text', 'Custom Title');
  });

  it('should pass props to popover via controller', () => {
@@ -195,6 +195,44 @@ describe('Overlays', () => {
      didDismiss: 2
    });
  });
+
+  it('should unmount modal via component', () => {
+    cy.get('ion-radio#ion-modal').click();
+    cy.get('ion-radio#component').click();
+
+    cy.get('ion-button#present-overlay').click();
+    cy.get('ion-modal').should('exist');
+
+    cy.get('ion-modal ion-input').should('have.value', '');
+    cy.get('ion-modal ion-input').type('1');
+
+    cy.get('ion-modal #dismiss').click();
+
+    cy.get('ion-button#present-overlay').click();
+    cy.get('ion-modal').should('exist');
+
+    cy.get('ion-modal ion-input').should('have.value', '');
+  });
+
+
+  it('should unmount modal via controller', () => {
+    cy.get('ion-radio#ion-modal').click();
+    cy.get('ion-radio#controller').click();
+
+    cy.get('ion-button#present-overlay').click();
+    cy.get('ion-modal').should('exist');
+
+    cy.get('ion-modal ion-input').should('have.value', '');
+    cy.get('ion-modal ion-input').type('1');
+
+    cy.get('ion-modal #dismiss').click();
+
+    cy.get('ion-button#present-overlay').click();
+    cy.get('ion-modal').should('exist');
+
+    cy.get('ion-modal ion-input').should('have.value', '');
+  });
+
 })

 const testLifecycle = (selector, expected = {}) => {
Author	SHA1	Message	Date
ionitron	a128c5156b	v6.4.4	2023-01-25 14:04:53 +00:00
Sean Perkins	e75f050be5	fix(vue): unmount teleported components (#26647 ) Resolves #26644	2023-01-25 08:36:28 -05:00
Liam DeBeasi	8e34ba0838	merge release-6.4.3 Release 6.4.3	2023-01-18 09:34:32 -05:00
Liam DeBeasi	be1a5af77e	merge release-6.4.2 Release 6.4.2	2023-01-11 09:15:38 -05:00
Liam DeBeasi	e266e08597	merge release-6.4.1 Release 6.4.1	2022-12-14 12:38:05 -05:00
Liam DeBeasi	bf79814500	merge release-6.4.0 Release 6.4.0	2022-12-07 10:23:33 -05:00
Liam DeBeasi	deabaca35d	merge release-6.3.10 Release 6.3.10	2022-12-07 09:25:04 -05:00
Liam DeBeasi	befd66010b	merge release-6.3.9 Release 6.3.9	2022-11-30 09:44:24 -05:00
Liam DeBeasi	a94510bc00	merge release-6.3.8 Release 6.3.8	2022-11-22 10:44:15 -05:00
Liam DeBeasi	fa01664477	merge release-6.3.7 Release 6.3.7	2022-11-16 11:21:09 -05:00
Sean Perkins	5c23dc871f	merge release-6.3.6 Release 6.3.6	2022-11-10 12:14:00 -05:00
Liam DeBeasi	712f77836d	merge release-6.3.5 Release 6.3.5	2022-11-09 09:32:22 -05:00
Liam DeBeasi	469842c7c5	merge release-6.3.4 Release 6.3.4	2022-11-02 10:23:37 -04:00
Liam DeBeasi	ae861b5081	merge release-6.3.3 Release 6.3.3	2022-10-26 09:15:06 -05:00
Liam DeBeasi	0b55c51ce9	merge release-6.3.2 Release 6.3.2	2022-10-17 10:39:53 -05:00
Liam DeBeasi	d75c70518a	merge release-6.3.1 Release 6.3.1	2022-10-12 10:06:50 -05:00
Liam DeBeasi	1a77a92832	merge release-6.3.0 Release 6.3.0	2022-10-05 12:08:56 -05:00
Liam DeBeasi	1ecc5b0bf5	merge release-6.2.9 Release 6.2.9	2022-09-28 09:15:22 -05:00
Liam DeBeasi	b507b13c60	merge release-6.2.8 Release 6.2.8	2022-09-21 09:08:20 -05:00
Liam DeBeasi	221aeffcf1	merge release-6.2.7 Release 6.2.7	2022-09-14 09:42:56 -05:00
Liam DeBeasi	60a88b667c	merge release-6.2.6 Release 6.2.6	2022-09-07 11:20:03 -05:00
Liam DeBeasi	2a58a86d7c	merge release-6.2.5 Release 6.2.5	2022-08-31 09:49:23 -05:00
Liam DeBeasi	39841019af	merge release-6.2.4 Release 6.2.4	2022-08-24 08:53:47 -05:00
Liam DeBeasi	4232449215	merge release-6.2.3 Release 6.2.3	2022-08-17 13:06:09 -05:00
Liam DeBeasi	d21b6cd084	merge release-6.2.2 Release 6.2.2	2022-08-10 14:39:08 -05:00
Liam DeBeasi	e60e700ae0	merge release-6.2.1 Release 6.2.1	2022-08-03 10:04:37 -04:00
Liam DeBeasi	96d08cfc80	merge release-6.2.0 Release 6.2.0	2022-07-27 14:30:00 -04:00
Liam DeBeasi	8d9b0f9484	merge release-6.1.15 Release 6.1.15	2022-07-20 10:59:14 -04:00
Liam DeBeasi	9fac36ab47	merge release-6.1.14 Release 6.1.14	2022-07-13 09:54:54 -04:00
Liam DeBeasi	4e3726e9bb	merge release-6.1.13 Release 6.1.13	2022-07-06 12:27:41 -04:00
Liam DeBeasi	244229a369	merge release-6.1.12 Release 6.1.12	2022-06-29 10:08:54 -04:00
Liam DeBeasi	9a611ae4d4	merge release-6.1.11 Release 6.1.11	2022-06-22 10:47:32 -04:00
Liam DeBeasi	9c8e36ceff	merge release-6.1.10 Release 6.1.10	2022-06-15 10:28:08 -04:00
Liam DeBeasi	b7858ea993	merge release-6.1.9 Release 6.1.9	2022-06-08 09:59:01 -04:00
Liam DeBeasi	af5bd6e78b	merge release-6.1.8 Release 6.1.8	2022-06-01 09:37:04 -04:00
Liam DeBeasi	4786abda3f	merge release-6.1.7 Release 6.1.7	2022-05-26 17:18:03 -04:00
Liam DeBeasi	8515879bde	merge release-6.1.6 Release 6.1.6	2022-05-18 09:18:21 -04:00
Liam DeBeasi	4a19eeaaf2	merge release-6.1.5 Release 6.1.5	2022-05-11 10:09:20 -04:00
Liam DeBeasi	ce65b0eaa0	merge release-6.1.4 Release 6.1.4	2022-05-04 12:27:20 -04:00
Liam DeBeasi	781a35dd56	merge release-6.1.3 Release 6.1.3	2022-04-27 20:27:38 +05:45
Liam DeBeasi	5c4724d5cb	merge release-6.1.2 Release 6.1.2	2022-04-20 19:44:16 +05:45
Liam DeBeasi	4cd34e0a0e	merge release-6.1.1 Release v6.1.1	2022-04-15 20:02:08 +05:45
Liam DeBeasi	6c4578c692	Merge branch '6.1.x' into release-6.1.1-conflict	2022-04-15 19:40:52 +05:45
Liam DeBeasi	36dda67872	merge release-6.1.0 Release 6.1.0	2022-04-13 10:23:47 -04:00
Liam DeBeasi	6f914e3b90	chore(): resolve merge conflicts	2022-04-13 10:02:38 -04:00
Liam DeBeasi	048ca440ae	merge release-6.0.16 Release 6.0.16	2022-04-08 09:57:08 -04:00
github-actions	d0f7b8f443	v6.0.16	2022-04-08 13:25:35 +00:00
Liam DeBeasi	fb994fa9a7	fix(angular): button components now route correctly without reload (#25071 )	2022-04-08 09:21:56 -04:00
Liam DeBeasi	a83fa402cf	merge release-6.0.15 Release 6.0.15	2022-04-06 16:08:26 -04:00
github-actions	9532d04608	v6.0.15	2022-04-06 19:04:14 +00:00
Liam DeBeasi	bafd1871ce	merge release-6.0.14 Release 6.0.14	2022-03-30 09:45:18 -04:00
Liam DeBeasi	7f3de340a7	merge release-6.0.13 Release 6.0.13	2022-03-23 09:39:28 -04:00
Liam DeBeasi	60dfe41741	merge release-6.0.12 Release 6.0.12	2022-03-16 09:37:12 -04:00
Liam DeBeasi	c983abeb3e	merge release-6.0.11 Release 6.0.11	2022-03-10 08:54:21 -05:00
Liam DeBeasi	80022a36ae	merge release-6.0.10 Release 6.0.10	2022-03-02 17:42:31 -05:00
Sean Perkins	d1602183a7	merge release-6.0.9 Release 6.0.9	2022-02-23 13:14:51 -05:00
Liam DeBeasi	59ed574685	merge release-6.0.8 Release 6.0.8	2022-02-15 16:49:10 -05:00
Liam DeBeasi	4fa8565788	merge release-6.0.7 Release 6.0.7	2022-02-09 11:45:31 -05:00
Liam DeBeasi	544c510ec8	merge release-6.0.6 Release 6.0.6	2022-02-09 10:43:21 -05:00
Liam DeBeasi	e6322ebcff	merge release-6.0.5 Release 6.0.5	2022-02-02 10:02:56 -05:00
Liam DeBeasi	4025eafe3b	merge release-6.0.4 Release 6.0.4	2022-01-26 15:36:18 -05:00
Liam DeBeasi	4785a7a929	merge release-6.0.3 Release 6.0.3	2022-01-19 10:21:21 -05:00
Liam DeBeasi	7d562e1e03	merge release-6.0.2 Release 6.0.2	2022-01-11 12:32:33 -05:00