Commit Graph

226 Commits

Author SHA1 Message Date
Liam DeBeasi
fd65765bdf fix(nav): prevent completing transition from being interrupted (#19113)
* do not enable swipe to begin before previous one has ended

* update defaults

* use canStart instead

* pause animations on finish

* remove old pause code
2019-08-16 13:33:39 -04:00
Liam DeBeasi
624e118b56 fix(animation): prevent animation re-run when toggling element visibility (#19115)
* clean up pause fn, rename oneTime to oneTimeCallback

* remove duration, play state, and delay from animations to prevent reruns when toggling visibility
2019-08-16 10:18:06 -04:00
Liam DeBeasi
7f39f8c357 perf(animation): improve reliability of reusing animation (#19106)
* fix race condition on reset

* fix linter

* fix linter

* remove unneeded pause at end
2019-08-15 10:08:55 -04:00
Liam DeBeasi
0b1e23f754 perf(animation): remove display: none check (#19086)
* wrap offsetParent in raf

* Revert "wrap offsetParent in raf"
merge
This reverts commit 9910032964.

* remove display none check, add note to document
2019-08-13 14:46:40 -04:00
Liam DeBeasi
ce192713c3 fix(animations): gesture based animations no longer flicker on slower devices (#19083)
* remove unneeded step

* remove unneeded recursion
2019-08-13 09:57:50 -04:00
Liam DeBeasi
30ca46ab12 feat(animation): add animation utility (#18918)
* Add new keyframes proof of concept

* update esm import

* add base before and after methods, add tests

* add base before and after hooks

* update clean up methods, add tests

* add web animations support, change to arrow functions

* remove console logs

* add from, to, fromTo, and other properties

* add more tests, fix onFinish functionality, being testing with nav transitions

* add progress methods, use force linear

* run linter

* Add playSync

* integrate animations with framework components

* onFinish now supports multiple callbacks

* change const to let

* testing reverse

* add support for both animation utilities

* bug fix

* export createAnimation, a few tweaks

* add base tests

* fix issue with onFinish being called out of order. added tests

* fix race conditions in tests

* clean up

* fix bug where onFinish not calling for empty elements array,  update test

* clean up

* fix treeshaking, remove old comments

* remove old tests

* Add test for animationbuilder backwards compat

* update typings for menu controller

* mock web animations in tests

* run build

* fix type errors

* sync with master

* use requestAnimationFrame instead of writeTask

* fix flaky tests, fix menu

* fix ordering

* update webdriver

* fix wrong version

* Revert "fix wrong version"

This reverts commit be91296e97.

Revert chromedriver update

* Revert "update webdriver"

This reverts commit e49bc9d76e.

Revert chromedriver update

* expose raw animation object, add tests

* add stylesheet recycling

* finalize before and after hook tests

* a few styling changes

* fix lint warnings

* get rid of old code

* Fix progressStep overflow bug

* disable reuse stylesheet

* small updates

* fix old animation create

* setStyleProperty helper

* reuse keyframe styles

* keyframes

* fix css animation issue with display: none, add tests

* add comment

* fix issue with progress animations and css animations

* clean up

* clean up pt2

* fix tests

* fix linter

* add fill for overlays

* fix swipe to go back

* clean up css animations when done

* fix edge cases with css animations

* fix menu open and close

* add reset function

* clean up reset fn

* Fix issue where animation always being reset

* allow updating animations on the fly

* add clear onfinish method

* fix linter

* add callback options, expand force direction

* ensure opts is defined

* fix css animations open and close for menus

* remove test

* add extra check

* clean up

* fix css anim bug swipe to go back

* fix pause

* setup alt animation to avoid flickering

* clean up

* reset flags on destroy

* add ability to change duration on progressEnd

* fix flicker on duration change for css animations

* fix ios transition

* remove unneeded recursion

* increase durability of updating css animations on the fly

* fix gesture anim

* fix web anim as well. more work for cleanup

* simplify progressEnd for css animations

* fix swipe to go back race condition

* clean up

* Add todo

* fix one more bug
2019-08-12 10:05:04 -04:00
Robin
e8cdda0fae fix(platform): set correct electron regex (#19044)
fixes #19043
2019-08-08 20:35:43 +02:00
Manu MA
7c48500f27 refactor(platform): isPlatform() does not need window (#19022) 2019-08-08 17:24:54 +02:00
Manu MA
e82648bda2 refactor(all): update to one (part 3) (#18874) 2019-07-25 20:22:44 +02:00
Manu MA
71137a2ffa fix(tap-click): ensure ripple is removed (#18854)
fixes #18836
2019-07-22 18:54:50 +02:00
Adam Bradley
9b075ef529 feat(transition): iOS page transition shadow (#18695)
Closes #18661
2019-07-18 14:50:56 -05:00
Manu MA
03c1d19e07 perf(all): minify better by using arrow functions (#18730) 2019-07-10 10:33:33 -04:00
Brandy Carney
0031ab82b7 style(lint): fix lint issues 2019-07-08 11:11:49 -04:00
Manu Mtz.-Almeida
e059fc8048 perf(angular): skip zone 2019-07-06 19:33:34 +02:00
Manu MA
301b0fc1d1 chore(): update to stencil 1.1 (#18609) 2019-06-26 17:17:48 +02:00
Manu MA
34dfc3ce98 refactor(all): updating to newest stencil apis (#18578)
* chore(): update ionicons

* refactor(all): updating to newest stencil apis

* fix lint issues

* more changes

* moreee

* fix treeshaking

* fix config

* fix checkbox

* fix stuff

* chore(): update ionicons

* fix linting errors
2019-06-23 11:26:42 +02:00
Manu MA
b40f7d36d5 fix(): update to Stencil One 🎉🎊 2019-06-19 21:33:50 +02:00
Brandy Carney
eca4121dc6 feat(components): add missing button/a props to components that render them (#17883)
Adds the following properties to the components listed under them:

`rel`, `download`, `target`:
- anchor
- button
- card
- fab-button
- item-option
- item
- tab-button

`disabled`:
- back-button
- menu-button

`type`:
- back-button
- item-option
- menu-button
- segment-button

fixes #16848 closes #16889


Co-authored-by: bitflower <matthias.max@bitflower.net>
2019-06-12 14:06:29 -04:00
Cezary Kluczyński
54bdb367c2 fix(platform): prevent error with Platform.is on Android 4.4 (#18387) 2019-06-10 10:47:23 -04:00
Cody Sand
b2290a6420 fix(content): prevent ion-searchbar from receiving padding adjustment (#18008)
* Fixes #18007 - check for fixed containing element and don't adjust ion-content padding.

* fix lint issue

* searchbar does not receive padding fix

* remove fixed slot check
2019-05-29 15:35:07 -04:00
Brandy Carney
4bba540311 fix(label): include the ion-text-wrap class styles for larger font (#18374)
- updates all e2e tests to use the CSS classes instead of attributes
2019-05-24 11:18:28 -04:00
Liam DeBeasi
adaaf89737 chore(): remove debug and log statements (#18245)
fixes #18190
2019-05-21 14:55:41 -04:00
Matt
3cad7787c2 fix(input): keep entire input in view when scrolling with keyboard open (#18253)
fixes #17457
2019-05-14 11:41:58 -04:00
Liam DeBeasi
ba0def3a38 bug(security): allow name and slot attributes when sanitizing (#18246)
* allow name attribute

* also add slot
2019-05-14 11:28:31 -04:00
Liam DeBeasi
d12757f975 fix(): sanitize components using innerHTML (#18083)
fixes #18065
2019-04-26 11:56:37 -04:00
Liam DeBeasi
2457a23e95 fix(): add prefixed transform for older versions of chrome (#18128)
fixes #17729
2019-04-25 11:57:25 -04:00
Brandy Carney
3cdab10aa0 fix(textarea): reposition textarea when keybard appears (#18098)
fixes #17847
2019-04-24 12:33:22 -04:00
Brandy Carney
9e63947e3c fix(action-sheet): default buttons to empty array
fixes an error with the timing of the buttons being added
2019-04-17 12:56:32 -04:00
Brandy Carney
e5c8c10029 fix(components): include mode classes on components for use in shadow (#17838)
- removes mode-less component classes from the internal CSS, use element instead
- adds mode specific classes `md` or `ios` for styling inside of shadow components
- adds e2e test that verifies mode classes exist on all ionic components, plus checks for specific classes that the components need for internal styling

fixes #17608
2019-04-16 17:28:21 -04:00
Liam DeBeasi
1199c53437 test(): remove custom screenshot names (#18022)
* test(): remove custom screenshot names

* update test names
2019-04-12 13:02:03 -04:00
Brandy Carney
2ceacf9d50 remove commented out file 2019-04-02 17:49:15 -04:00
Adam LaCombe
352797e932 fix(reorder-group): add ability to reorder items inside shadow (#17747)
- adds ability to reorder items from within a shadow dom component
- adds interactive test

fixes #17746
2019-03-26 17:00:44 -04:00
Liam DeBeasi
b6569254a3 fix(datetime): recalculate day column when month is changed (#17846)
Co-Authored-By: KillerCodeMonkey <bengtler@gmail.com>
Co-Authored-By: olivercodes <boliver@linux.com>
Co-Authored-By: liamdebeasi <liamdebeasi@users.noreply.github.com>
2019-03-21 09:07:44 -04:00
Liam DeBeasi
e915aeda6b Revert "fix(datetime): recalculate day column when month or year is changed (#17815)" (#17845)
This reverts commit 9273f97a0c.
2019-03-21 09:06:06 -04:00
Liam DeBeasi
9273f97a0c fix(datetime): recalculate day column when month or year is changed (#17815)
Co-Authored-By: KillerCodeMonkey<bengtler@gmail.com>
Co-Authored-By: olivercodes <boliver@linux.com>
Co-Authored-By: liamdebeasi <liamdebeasi@users.noreply.github.com>
2019-03-21 08:51:06 -04:00
Liam DeBeasi
29dbd0770c fix(platform): account for larger tablets (#17630)
* fix(platform): account for larger tablets

* lint files

* add utils file, clean up tests, add more tests

* update tests with extra desktop checks

* change window to win
2019-03-15 13:43:39 -04:00
Zachary Keeton
7d0120789c fix(transition): animate all toolbars in iOS page transitions (#17224)
* fix(transition): add all header toolbars to ios transition

* test(nav): add 2nd toolbar to test transition

* fix(transition): add remaining toolbar children to animation

* fix(transition): fix incorrect variable name

* fix(toolbar): fix bug in safari, clean up code, update test

* fix typo

* change elems to els

* change Elem to El
2019-03-14 15:38:40 -04:00
Liam DeBeasi
ad20bd6a70 fix(animation): fix header flicker on ios (#17422)
* add initial fix for flicker on ios

* fix(transition): do not remove opacity from outgoing element
2019-03-04 13:32:58 -05:00
Liam DeBeasi
f07ea4f7db test(): Take more screenshots, DRY up code, add more tests (#17534)
* test(toast): DRY up tests, add expanded tests, add rtl tests

* test(popover): add more screenshots, add rtl tests

* clean up tests a bit more

* test(modal): DRY up tests, add RTL tests

* add missing type to util function

* add utils file, update standlone test

* update standalone tests, add utils file

* test(menu): DRY up tests, add rtl tests

* test(loading): DRY up tests, add rtl tests, add utils file

* lint files

* test(alert): add more screenshots, dry up tests

* fix potential race condition

* remove artificial delay

* lint files

* lint files

* remove artificial delays

* remove artificial delay

* add initial test updates, need to figure out alert from action sheet

* test(): dry up tests some more, add generic utils file

* lint files

* add hook

* fix typescript error
2019-03-01 10:41:55 -05:00
Adam Bradley
f44c17e03b fix(ssr): fix angular global window and document references 2019-02-25 16:43:41 -06:00
Adam Bradley
4646f53ec7 fix(ssr): fix global window and document references (#17590) 2019-02-22 20:13:09 -06:00
Fer Medina
39fbc32348 fix(config): update types for scrollPadding, inputBlurring and hideCaretOnScroll to boolean (#17302) 2019-02-12 16:49:03 -05:00
Liam DeBeasi
08879c08a3 test(platform): Add Platform tests (#17354)
* test(platform): add base platform tests

* test(platform): add isPlatform test, clean up test file

* test(platform): do not export matchMedia

* test(platform): change window to win to avoid confusion
2019-02-05 12:06:00 -05:00
Liam DeBeasi
c27d1827b7 Merge branch 'master' into update-pwa-check 2019-02-04 10:39:19 -05:00
Liam DeBeasi
a584f6e6da fix(platform): add additional check for safari PWA 2019-02-01 09:36:57 -05:00
Liam DeBeasi
cf2b2b370a feat(platform): add mobileweb platform 2019-02-01 08:43:32 -05:00
Manu MA
2b4d7b7be9 fix(angular): apply validation classes properly
* fix(angular): add validation classes to ion-item

* fix(inputs): focus handling

fixes #17171
fixes #16052
fixes #15572
fixes #16452
fixes #17063
2019-01-19 22:56:00 +01:00
Manu MA
5cb7f68ee2 fix(content): tap-click deadlock (#17170)
fixes #17138
fixes #16863
fixes #16191
fixes #16911
2019-01-18 18:53:35 +01:00
Paul Stelzer
b0f51d4989 fix(utils): remove console log (#17116) 2019-01-15 11:47:01 +01:00
Manu MA
6364e4e2a1 fix(inputs): keyboard focus improvements (#16838)
fixes #16815
fixes #16872
fixes #13978
fixes #16610
2019-01-11 19:36:02 +01:00